pgsql: Add COMMENT and SECURITY LABEL support for publications and subs
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t36331psql -h localhost -U postgresBuilt from patchset v3 (message #3), July 28, 2026 at 07:25 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t36331_3 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t36331_3 && git checkout t36331_3Patchset v3 (message #3) is on t36331_3
Add COMMENT and SECURITY LABEL support for publications and subscriptions
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/87dee41f3ed6d6c2a93e7ff359776cfe24f145e0
Modified Files
--------------
doc/src/sgml/ref/comment.sgml | 2 ++
doc/src/sgml/ref/security_label.sgml | 2 ++
src/backend/catalog/system_views.sql | 22 +++++++++++++++
src/backend/parser/gram.y | 4 +++
.../dummy_seclabel/expected/dummy_seclabel.out | 32 ++++++++++++++--------
.../modules/dummy_seclabel/sql/dummy_seclabel.sql | 7 +++++
src/test/regress/expected/publication.out | 7 +++++
src/test/regress/expected/rules.out | 23 ++++++++++++++++
src/test/regress/expected/subscription.out | 7 +++++
src/test/regress/sql/publication.sql | 3 ++
src/test/regress/sql/subscription.sql | 3 ++
11 files changed, 100 insertions(+), 12 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Peter,
* Peter Eisentraut (peter_e@gmx.net) wrote:
Add COMMENT and SECURITY LABEL support for publications and subscriptions
Isn't this missing psql tab completion, and pg_dump support? And
regression tests for the latter?
Thanks!
Stephen
On 3/25/17 12:24, Stephen Frost wrote:
Add COMMENT and SECURITY LABEL support for publications and subscriptions
Isn't this missing psql tab completion, and pg_dump support? And
regression tests for the latter?
I have added the tab completion support.
Attached is a patch that adds the pg_dump support, but I'm struggling to
make the tests work. Could you take a look? Problem one I'm seeing is
that the tests assert that there are no comments in the post-data
section, which is no longer the case here. Problem two is that
subscriptions are not dumped by default, so those new tests fail, but I
don't understand why the existing tests about subscriptions work so far.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Peter,
* Peter Eisentraut (peter.eisentraut@2ndquadrant.com) wrote:
On 3/25/17 12:24, Stephen Frost wrote:
Add COMMENT and SECURITY LABEL support for publications and subscriptions
Isn't this missing psql tab completion, and pg_dump support? And
regression tests for the latter?I have added the tab completion support.
Thanks!
Attached is a patch that adds the pg_dump support, but I'm struggling to
make the tests work. Could you take a look? Problem one I'm seeing is
that the tests assert that there are no comments in the post-data
section, which is no longer the case here.
If that's the case (and is intended), then you'll need to remove the
'section_post_data' entry from the COMMENTS catch-all 'unlike' and move
that into the 'unlike' for each of the COMMENT tests which were
depending on the catch-all to handle that.
The other approach is to create a new catch-all which catches COMMENTs
that are not pub/sub and have the other COMMENT tests use that but have
a different catch-all for the pub/sub entries or just have all of the
tests covered by them. There are a few examples of this approach
already (off-hand, I think there's one related to blobs).
Problem two is that
subscriptions are not dumped by default, so those new tests fail, but I
don't understand why the existing tests about subscriptions work so far.
There are (or were?) some tests which explicitly use
'--include-subscription'. You can see how each test's pg_dump is run in
the hash at the top.
I thought we were changing that anyway though? To dump subscriptions by
default but to have them dumped in a 'not enabled' fashion? In fact, I
thought that had already happened, but I might be thinking of something
else.
Thanks!
Stephen
On 4/4/17 09:59, Stephen Frost wrote:
Attached is a patch that adds the pg_dump support, but I'm struggling to
make the tests work. Could you take a look? Problem one I'm seeing is
that the tests assert that there are no comments in the post-data
section, which is no longer the case here.If that's the case (and is intended), then you'll need to remove the
'section_post_data' entry from the COMMENTS catch-all 'unlike' and move
that into the 'unlike' for each of the COMMENT tests which were
depending on the catch-all to handle that.
done
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers