the need to finish

Started by Erik Rijkersalmost 9 years ago4 messages

er@xs4all.nl

almost 9 years ago

Logical replication emits logmessages like these:

DETAIL: 90 transactions need to finish.
DETAIL: 87 transactions need to finish.
DETAIL: 70 transactions need to finish.

Could we get rid of that 'need'? It strikes me as a bit off; something
that people would say but not a mechanical message by a computer. I
dislike it strongly.

I would prefer the line to be more terse:

DETAIL: 90 transactions to finish.

Am I the only one who is annoyed by this phrase?

Thanks,

Erik Rijkers

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Tom Lane

tgl@sss.pgh.pa.us

almost 9 years ago

In reply to: Erik Rijkers (#1)

Re: the need to finish

Erik Rijkers <er@xs4all.nl> writes:

Logical replication emits logmessages like these:
DETAIL: 90 transactions need to finish.
DETAIL: 87 transactions need to finish.
DETAIL: 70 transactions need to finish.

Could we get rid of that 'need'? It strikes me as a bit off; something
that people would say but not a mechanical message by a computer. I
dislike it strongly.

I would prefer the line to be more terse:

DETAIL: 90 transactions to finish.

Am I the only one who is annoyed by this phrase?

Our style guidelines say that detail messages should be complete
sentences, so I don't like your proposal too much.

Maybe "N transactions remain to finish." ?

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Simon Riggs

simon@2ndquadrant.com

almost 9 years ago

In reply to: Tom Lane (#2)

Re: the need to finish

On 12 April 2017 at 16:26, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Erik Rijkers <er@xs4all.nl> writes:

Logical replication emits logmessages like these:
DETAIL: 90 transactions need to finish.
DETAIL: 87 transactions need to finish.
DETAIL: 70 transactions need to finish.

Could we get rid of that 'need'? It strikes me as a bit off; something
that people would say but not a mechanical message by a computer. I
dislike it strongly.

I would prefer the line to be more terse:

DETAIL: 90 transactions to finish.

Am I the only one who is annoyed by this phrase?

Our style guidelines say that detail messages should be complete
sentences, so I don't like your proposal too much.

Maybe "N transactions remain to finish." ?

waiting for N transactions to complete

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Robert Haas

robertmhaas@gmail.com

almost 9 years ago

In reply to: Simon Riggs (#3)

Re: the need to finish

On Wed, Apr 12, 2017 at 11:41 AM, Simon Riggs <simon@2ndquadrant.com> wrote:

On 12 April 2017 at 16:26, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Erik Rijkers <er@xs4all.nl> writes:

Logical replication emits logmessages like these:
DETAIL: 90 transactions need to finish.
I would prefer the line to be more terse:
DETAIL: 90 transactions to finish.

Our style guidelines say that detail messages should be complete
sentences, so I don't like your proposal too much.
Maybe "N transactions remain to finish." ?

waiting for N transactions to complete

+1 for something along those lines, but perhaps it needs a capital
letter and a period.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers