Error message on missing SCRAM authentication with older clients

Started by Heikki Linnakangasalmost 9 years ago8 messageshackers
Jump to latest
#1Heikki Linnakangas
heikki.linnakangas@enterprisedb.com

Currently, if you use 9.6 libpq to connect to a v10 server that requires
SCRAM authentication, you get an error:

psql: authentication method 10 not supported

I'd like to apply this small patch to all the stable branches, to give a
nicer error message:

psql: SCRAM authentication not supported by this version of libpq

It won't help unless you upgrade to the latest minor version, of course,
but it's better than nothing. Any objections?

- Heikki

Attachments:

backport-nicer-error-on-scram.patchinvalid/octet-stream; name=backport-nicer-error-on-scram.patchDownload+15-0
#2Aleksander Alekseev
aleksander@timescale.com
In reply to: Heikki Linnakangas (#1)
Re: Error message on missing SCRAM authentication with older clients

Hi Heikki,

psql: SCRAM authentication not supported by this version of libpq

Maybe it would be better to specify a minimum required version?

--
Best regards,
Aleksander Alekseev

#3Magnus Hagander
magnus@hagander.net
In reply to: Heikki Linnakangas (#1)
Re: Error message on missing SCRAM authentication with older clients

On Wed, May 3, 2017 at 10:58 AM, Heikki Linnakangas <hlinnakangas@pivotal.io

wrote:

Currently, if you use 9.6 libpq to connect to a v10 server that requires
SCRAM authentication, you get an error:

psql: authentication method 10 not supported

I'd like to apply this small patch to all the stable branches, to give a
nicer error message:

psql: SCRAM authentication not supported by this version of libpq

It won't help unless you upgrade to the latest minor version, of course,
but it's better than nothing. Any objections?

+1, even though it's not strictly speaking a bugfix to go in a backpatch, I
think it will help enough users that it's worth doing. And I can't see how
it could possibly be unsafe...

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/&gt;
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/&gt;

#4Aleksander Alekseev
aleksander@timescale.com
In reply to: Magnus Hagander (#3)
Re: Error message on missing SCRAM authentication with older clients

Hi Magnus,

+1, even though it's not strictly speaking a bugfix to go in a backpatch, I
think it will help enough users that it's worth doing. And I can't see how
it could possibly be unsafe...

Well, strictly speaking there could be applications that parse error
messages using regular expressions or something like this. But I don't
think it's something we should really bother about.

--
Best regards,
Aleksander Alekseev

#5Heikki Linnakangas
heikki.linnakangas@enterprisedb.com
In reply to: Aleksander Alekseev (#2)
Re: Error message on missing SCRAM authentication with older clients

On 05/03/2017 03:12 PM, Aleksander Alekseev wrote:

Hi Heikki,

psql: SCRAM authentication not supported by this version of libpq

Maybe it would be better to specify a minimum required version?

Yeah, that could be helpful. Can you suggest a wording?

My first thought was:

psql: SCRAM authentication not supported by this version of libpq
(version 10 or above required)

But that's very long. Perhaps:

psql: SCRAM authentication requires libpq version 10 or above

- Heikki

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#6Aleksander Alekseev
aleksander@timescale.com
In reply to: Heikki Linnakangas (#5)
Re: Error message on missing SCRAM authentication with older clients

Hi Heikki,

psql: SCRAM authentication requires libpq version 10 or above

Sounds good.

--
Best regards,
Aleksander Alekseev

#7Magnus Hagander
magnus@hagander.net
In reply to: Aleksander Alekseev (#6)
Re: Error message on missing SCRAM authentication with older clients

On Fri, May 5, 2017 at 10:19 AM, Aleksander Alekseev <
a.alekseev@postgrespro.ru> wrote:

Hi Heikki,

psql: SCRAM authentication requires libpq version 10 or above

Sounds good.

+1.

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/&gt;
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/&gt;

#8Heikki Linnakangas
heikki.linnakangas@enterprisedb.com
In reply to: Magnus Hagander (#7)
Re: Error message on missing SCRAM authentication with older clients

On 05/05/2017 11:26 AM, Magnus Hagander wrote:

On Fri, May 5, 2017 at 10:19 AM, Aleksander Alekseev <
a.alekseev@postgrespro.ru> wrote:

psql: SCRAM authentication requires libpq version 10 or above

Sounds good.

+1.

Ok, committed. Thanks!

- Heikki

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers