synchronous_commit option is not visible after pressing TAB

Started by tusharover 9 years ago4 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t36707
psql -h localhost -U postgres

Built from patchset v4 (message #4), July 28, 2026 at 06:40 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t36707_4 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t36707_4 && git checkout t36707_4

Patchset v4 (message #4) is on t36707_4

Jump to latest
#1tushar
tushar.ahuja@enterprisedb.com

Hi,

While creating subscription - if we press TAB button to see the
available parameters , synchronous_commit parameter is not visible.

postgres=# CREATE SUBSCRIPTION sub123 CONNECTION 'dbname=postgres
port=5000' PUBLICATION pub WITH (<Press TAB>
CONNECT COPY_DATA CREATE_SLOT ENABLED SLOT_NAME

synchronous_commit option is not visible

--
regards,tushar
EnterpriseDB https://www.enterprisedb.com/
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#2Michael Paquier
michael@paquier.xyz
In reply to: tushar (#1)
Re: synchronous_commit option is not visible after pressing TAB

On Tue, May 16, 2017 at 8:18 PM, tushar <tushar.ahuja@enterprisedb.com> wrote:

While creating subscription - if we press TAB button to see the available
parameters , synchronous_commit parameter is not visible.

postgres=# CREATE SUBSCRIPTION sub123 CONNECTION 'dbname=postgres port=5000'
PUBLICATION pub WITH (<Press TAB>
CONNECT COPY_DATA CREATE_SLOT ENABLED SLOT_NAME

synchronous_commit option is not visible

Yes, and the items should be ordered alphabetically.
--
Michael

Attachments:

create-sub-tab.patchapplication/octet-stream; name=create-sub-tab.patchDownload+2-2
#3Peter Eisentraut
peter_e@gmx.net
In reply to: Michael Paquier (#2)
Re: synchronous_commit option is not visible after pressing TAB

On 5/16/17 19:45, Michael Paquier wrote:

On Tue, May 16, 2017 at 8:18 PM, tushar <tushar.ahuja@enterprisedb.com> wrote:

While creating subscription - if we press TAB button to see the available
parameters , synchronous_commit parameter is not visible.

postgres=# CREATE SUBSCRIPTION sub123 CONNECTION 'dbname=postgres port=5000'
PUBLICATION pub WITH (<Press TAB>
CONNECT COPY_DATA CREATE_SLOT ENABLED SLOT_NAME

synchronous_commit option is not visible

Yes, and the items should be ordered alphabetically.

Fixed. There were a few more things that needed tweaking, too.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Masahiko Sawada
sawada.mshk@gmail.com
In reply to: Peter Eisentraut (#3)
Re: synchronous_commit option is not visible after pressing TAB

On Wed, May 17, 2017 at 11:21 AM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:

On 5/16/17 19:45, Michael Paquier wrote:

On Tue, May 16, 2017 at 8:18 PM, tushar <tushar.ahuja@enterprisedb.com> wrote:

While creating subscription - if we press TAB button to see the available
parameters , synchronous_commit parameter is not visible.

postgres=# CREATE SUBSCRIPTION sub123 CONNECTION 'dbname=postgres port=5000'
PUBLICATION pub WITH (<Press TAB>
CONNECT COPY_DATA CREATE_SLOT ENABLED SLOT_NAME

synchronous_commit option is not visible

Yes, and the items should be ordered alphabetically.

Fixed. There were a few more things that needed tweaking, too.

In addition to that, attached patch fixes two tab completion issues.

* ALTER SUBSCRIPTION hoge_sub SET PUBLICATION hoge_pub [TAB]
-> Complete with "REFRESH ..." or "SKIP REFRESH".
* CREATE PUBLICATION hoge_pub FOR ALL TABLES [TAB] and CREATE
PUBLICATION hoge_pub FOR TABLE hoge_table [TAB]
-> Complete with "WITH ("

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachments:

t36707_4
fix_tab_completion.patchapplication/octet-stream; name=fix_tab_completion.patchDownload+22-0