synchronous_commit option is not visible after pressing TAB

Started by tusharalmost 9 years ago4 messageshackers
Jump to latest
#1tushar
tushar.ahuja@enterprisedb.com

Hi,

While creating subscription - if we press TAB button to see the
available parameters , synchronous_commit parameter is not visible.

postgres=# CREATE SUBSCRIPTION sub123 CONNECTION 'dbname=postgres
port=5000' PUBLICATION pub WITH (<Press TAB>
CONNECT COPY_DATA CREATE_SLOT ENABLED SLOT_NAME

synchronous_commit option is not visible

--
regards,tushar
EnterpriseDB https://www.enterprisedb.com/
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#2Michael Paquier
michael@paquier.xyz
In reply to: tushar (#1)
Re: synchronous_commit option is not visible after pressing TAB

On Tue, May 16, 2017 at 8:18 PM, tushar <tushar.ahuja@enterprisedb.com> wrote:

While creating subscription - if we press TAB button to see the available
parameters , synchronous_commit parameter is not visible.

postgres=# CREATE SUBSCRIPTION sub123 CONNECTION 'dbname=postgres port=5000'
PUBLICATION pub WITH (<Press TAB>
CONNECT COPY_DATA CREATE_SLOT ENABLED SLOT_NAME

synchronous_commit option is not visible

Yes, and the items should be ordered alphabetically.
--
Michael

Attachments:

create-sub-tab.patchapplication/octet-stream; name=create-sub-tab.patchDownload+2-2
#3Peter Eisentraut
peter_e@gmx.net
In reply to: Michael Paquier (#2)
Re: synchronous_commit option is not visible after pressing TAB

On 5/16/17 19:45, Michael Paquier wrote:

On Tue, May 16, 2017 at 8:18 PM, tushar <tushar.ahuja@enterprisedb.com> wrote:

While creating subscription - if we press TAB button to see the available
parameters , synchronous_commit parameter is not visible.

postgres=# CREATE SUBSCRIPTION sub123 CONNECTION 'dbname=postgres port=5000'
PUBLICATION pub WITH (<Press TAB>
CONNECT COPY_DATA CREATE_SLOT ENABLED SLOT_NAME

synchronous_commit option is not visible

Yes, and the items should be ordered alphabetically.

Fixed. There were a few more things that needed tweaking, too.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Masahiko Sawada
sawada.mshk@gmail.com
In reply to: Peter Eisentraut (#3)
Re: synchronous_commit option is not visible after pressing TAB

On Wed, May 17, 2017 at 11:21 AM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:

On 5/16/17 19:45, Michael Paquier wrote:

On Tue, May 16, 2017 at 8:18 PM, tushar <tushar.ahuja@enterprisedb.com> wrote:

While creating subscription - if we press TAB button to see the available
parameters , synchronous_commit parameter is not visible.

postgres=# CREATE SUBSCRIPTION sub123 CONNECTION 'dbname=postgres port=5000'
PUBLICATION pub WITH (<Press TAB>
CONNECT COPY_DATA CREATE_SLOT ENABLED SLOT_NAME

synchronous_commit option is not visible

Yes, and the items should be ordered alphabetically.

Fixed. There were a few more things that needed tweaking, too.

In addition to that, attached patch fixes two tab completion issues.

* ALTER SUBSCRIPTION hoge_sub SET PUBLICATION hoge_pub [TAB]
-> Complete with "REFRESH ..." or "SKIP REFRESH".
* CREATE PUBLICATION hoge_pub FOR ALL TABLES [TAB] and CREATE
PUBLICATION hoge_pub FOR TABLE hoge_table [TAB]
-> Complete with "WITH ("

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachments:

fix_tab_completion.patchapplication/octet-stream; name=fix_tab_completion.patchDownload+22-0