HINT message for "ALTER SUBSCRIPTION.. WITH" need to change with SET keyword

Started by tusharover 9 years ago3 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t36730
psql -h localhost -U postgres

Built from patchset v2 (message #2), July 28, 2026 at 06:40 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t36730_2 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t36730_2 && git checkout t36730_2

Patchset v2 (message #2) is on t36730_2

Jump to latest
#1tushar
tushar.ahuja@enterprisedb.com

Hi,

There is small issue in the HINT message which we provide at the time of
dropping subscription ,where we are saying -WITH (slot_name) which need
to change with SET (slot_name).

postgres=# drop subscription sub;
ERROR: could not connect to publisher when attempting to drop the
replication slot "pub"
DETAIL: The error was: could not connect to server: No such file or
directory
Is the server running locally and accepting
connections on Unix domain socket "/tmp/.s.PGSQL.5432"?
HINT: Use ALTER SUBSCRIPTION ... *WITH* (slot_name = NONE) to
disassociate the subscription from the slot.

expected = "HINT: Use ALTER SUBSCRIPTION ... *SET* (slot_name = NONE)
to disassociate the subscription from the slot."

--
regards,tushar
EnterpriseDB https://www.enterprisedb.com/
The Enterprise PostgreSQL Company

#2Dilip Kumar
dilipbalaut@gmail.com
In reply to: tushar (#1)
Re: HINT message for "ALTER SUBSCRIPTION.. WITH" need to change with SET keyword

On Fri, May 19, 2017 at 3:41 PM, tushar <tushar.ahuja@enterprisedb.com> wrote:

postgres=# drop subscription sub;
ERROR: could not connect to publisher when attempting to drop the
replication slot "pub"
DETAIL: The error was: could not connect to server: No such file or
directory
Is the server running locally and accepting
connections on Unix domain socket "/tmp/.s.PGSQL.5432"?
HINT: Use ALTER SUBSCRIPTION ... WITH (slot_name = NONE) to disassociate
the subscription from the slot.

expected = "HINT: Use ALTER SUBSCRIPTION ... SET (slot_name = NONE) to
disassociate the subscription from the slot."

Seems like syntax got changed in
b807f59828fbc02fea612e1cbc0066c6dfa3be9b commit but missed to change
the hint. Attached patch fixes that.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Attachments:

t36730_2
fix_subscription_hint.patchapplication/octet-stream; name=fix_subscription_hint.patchDownload+1-1
#3Peter Eisentraut
peter_e@gmx.net
In reply to: Dilip Kumar (#2)
Re: HINT message for "ALTER SUBSCRIPTION.. WITH" need to change with SET keyword

On 5/19/17 06:58, Dilip Kumar wrote:

On Fri, May 19, 2017 at 3:41 PM, tushar <tushar.ahuja@enterprisedb.com> wrote:

postgres=# drop subscription sub;
ERROR: could not connect to publisher when attempting to drop the
replication slot "pub"
DETAIL: The error was: could not connect to server: No such file or
directory
Is the server running locally and accepting
connections on Unix domain socket "/tmp/.s.PGSQL.5432"?
HINT: Use ALTER SUBSCRIPTION ... WITH (slot_name = NONE) to disassociate
the subscription from the slot.

expected = "HINT: Use ALTER SUBSCRIPTION ... SET (slot_name = NONE) to
disassociate the subscription from the slot."

Seems like syntax got changed in
b807f59828fbc02fea612e1cbc0066c6dfa3be9b commit but missed to change
the hint. Attached patch fixes that.

Fixed, thanks.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers