ECPG: pg_type.h file is not synced
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t36763psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 28, 2026 at 06:37 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t36763_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t36763_1 && git checkout t36763_1Patchset v1 (message #1) is on t36763_1
Hello,
I am looking at ECPG source code. In the "ecpg/ecpglib/pg_type.h" file I
have seen following comment:
** keep this in sync with src/include/catalog/pg_type.h*
But I think the "ecpg/ecpglib/pg_type.h" file is currently not synced
with the above file.
I have added the remaining types in the attached patch.
I would like to know whether we can add remaining types in the
"ecpg/ecpglib/pg_type.h" file or not?
Regards,
Vinayak Pokale
NTT Open Source Software Center
Hi,
I am looking at ECPG source code. In the "ecpg/ecpglib/pg_type.h" file I
have seen following comment:** keep this in sync with src/include/catalog/pg_type.h*
But I think the "ecpg/ecpglib/pg_type.h" file is currently not synced
with the above file.I have added the remaining types in the attached patch.
I would like to know whether we can add remaining types in the
"ecpg/ecpglib/pg_type.h" file or not?
It's not too big a deal as neither of the new OIDs is used in ecpg, but
still, the file should be up to date.
Thanks for the patch, committed.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Tue, May 23, 2017 at 10:25:13AM +0200, Michael Meskes wrote:
Hi,
I am looking at ECPG source code. In the "ecpg/ecpglib/pg_type.h" file I
have seen following comment:** keep this in sync with src/include/catalog/pg_type.h*
But I think the "ecpg/ecpglib/pg_type.h" file is currently not synced
with the above file.I have added the remaining types in the attached patch.
I would like to know whether we can add remaining types in the
"ecpg/ecpglib/pg_type.h" file or not?It's not too big a deal as neither of the new OIDs is used in ecpg, but
still, the file should be up to date.Thanks for the patch, committed.
Should we add some Makefile magic to make sure they stay in sync?
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
But I think the "ecpg/ecpglib/pg_type.h" file is currently not synced
with the above file.
Should we add some Makefile magic to make sure they stay in sync?
Not so much that as teach genbki.pl to generate this file too.
I think that might be a good idea, but personally I'd leave it until
after the genbki rewrite we keep talking about. This isn't important
enough to make that rewrite have an even higher hurdle to clear.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
But I think the "ecpg/ecpglib/pg_type.h" file is currently not
synced
with the above file.Should we add some Makefile magic to make sure they stay in sync?
Not so much that as teach genbki.pl to generate this file too.
I think that might be a good idea, but personally I'd leave it until
after the genbki rewrite we keep talking about. This isn't important
enough to make that rewrite have an even higher hurdle to clear.regards, tom lane
Agreed. We will only run into problems with ecpg if some of the
existing oids change. Newly added ones will not be referenced unless
ecpg receives changes, too.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, PostgreSQL
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers