simplehash.h typo
/* round up size to the next power of 2, that's the bucketing works */
That should probably be "that's the **way** bucketing works". Or maybe it
is an idiom I don't grok.
Cheers,
Jeff
On 05/28/2017 04:50 AM, Jeff Janes wrote:
/* round up size to the next power of 2, that's the bucketing works */
That should probably be "that's the **way** bucketing works". Or maybe it
is an idiom I don't grok.
Fixed, thanks. I also fixed and clarified some other comments in the
file that seemed wrong or confusing to me.
- Heikki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On 2017-06-05 11:10:12 +0300, Heikki Linnakangas wrote:
On 05/28/2017 04:50 AM, Jeff Janes wrote:
/* round up size to the next power of 2, that's the bucketing works */
That should probably be "that's the **way** bucketing works". Or maybe it
is an idiom I don't grok.
No, you're perfectly right!
Fixed, thanks. I also fixed and clarified some other comments in the file
that seemed wrong or confusing to me.
Thanks for looking - I don't see any commit though?
- Andres
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On 06/05/2017 11:26 AM, Andres Freund wrote:
On 2017-06-05 11:10:12 +0300, Heikki Linnakangas wrote:
Fixed, thanks. I also fixed and clarified some other comments in the file
that seemed wrong or confusing to me.Thanks for looking - I don't see any commit though?
Pushed now. Note to self: remove --dry-run when you intend to commit for
real :-).
- Heikki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers