syscache entries out of order
Peter,
Just FYI, as of 665d1fad99e7b11678b0d5fa24d2898424243cd6, syscache.h
entries are not in alphabetical order, which violates the coding standard
specified in the comment for these entries. In particular, it is the PUBLICATION
and SUBSCRIPTION entries that are mis-ordered.
Sorry for my pedantry. Patch attached.
Mark Dilger
Attachments:
syscache.patch.0application/octet-stream; name=syscache.patch.0Download
diff --git a/src/backend/utils/cache/syscache.c b/src/backend/utils/cache/syscache.c
index 922718c..e66bb03 100644
--- a/src/backend/utils/cache/syscache.c
+++ b/src/backend/utils/cache/syscache.c
@@ -606,6 +606,50 @@ static const struct cachedesc cacheinfo[] = {
},
128
},
+ {PublicationRelationId, /* PUBLICATIONNAME */
+ PublicationNameIndexId,
+ 1,
+ {
+ Anum_pg_publication_pubname,
+ 0,
+ 0,
+ 0
+ },
+ 8
+ },
+ {PublicationRelationId, /* PUBLICATIONOID */
+ PublicationObjectIndexId,
+ 1,
+ {
+ ObjectIdAttributeNumber,
+ 0,
+ 0,
+ 0
+ },
+ 8
+ },
+ {PublicationRelRelationId, /* PUBLICATIONREL */
+ PublicationRelObjectIndexId,
+ 1,
+ {
+ ObjectIdAttributeNumber,
+ 0,
+ 0,
+ 0
+ },
+ 64
+ },
+ {PublicationRelRelationId, /* PUBLICATIONRELMAP */
+ PublicationRelPrrelidPrpubidIndexId,
+ 2,
+ {
+ Anum_pg_publication_rel_prrelid,
+ Anum_pg_publication_rel_prpubid,
+ 0,
+ 0
+ },
+ 64
+ },
{RangeRelationId, /* RANGETYPE */
RangeTypidIndexId,
1,
@@ -661,50 +705,6 @@ static const struct cachedesc cacheinfo[] = {
},
16
},
- {PublicationRelationId, /* PUBLICATIONOID */
- PublicationObjectIndexId,
- 1,
- {
- ObjectIdAttributeNumber,
- 0,
- 0,
- 0
- },
- 8
- },
- {PublicationRelationId, /* PUBLICATIONNAME */
- PublicationNameIndexId,
- 1,
- {
- Anum_pg_publication_pubname,
- 0,
- 0,
- 0
- },
- 8
- },
- {PublicationRelRelationId, /* PUBLICATIONREL */
- PublicationRelObjectIndexId,
- 1,
- {
- ObjectIdAttributeNumber,
- 0,
- 0,
- 0
- },
- 64
- },
- {PublicationRelRelationId, /* PUBLICATIONRELMAP */
- PublicationRelPrrelidPrpubidIndexId,
- 2,
- {
- Anum_pg_publication_rel_prrelid,
- Anum_pg_publication_rel_prpubid,
- 0,
- 0
- },
- 64
- },
{RewriteRelationId, /* RULERELNAME */
RewriteRelRulenameIndexId,
2,
@@ -760,17 +760,6 @@ static const struct cachedesc cacheinfo[] = {
},
128
},
- {SubscriptionRelationId, /* SUBSCRIPTIONOID */
- SubscriptionObjectIndexId,
- 1,
- {
- ObjectIdAttributeNumber,
- 0,
- 0,
- 0
- },
- 4
- },
{SubscriptionRelationId, /* SUBSCRIPTIONNAME */
SubscriptionNameIndexId,
2,
@@ -782,6 +771,17 @@ static const struct cachedesc cacheinfo[] = {
},
4
},
+ {SubscriptionRelationId, /* SUBSCRIPTIONOID */
+ SubscriptionObjectIndexId,
+ 1,
+ {
+ ObjectIdAttributeNumber,
+ 0,
+ 0,
+ 0
+ },
+ 4
+ },
{SubscriptionRelRelationId, /* SUBSCRIPTIONRELMAP */
SubscriptionRelSrrelidSrsubidIndexId,
2,
diff --git a/src/include/utils/syscache.h b/src/include/utils/syscache.h
index e20284d..246601c 100644
--- a/src/include/utils/syscache.h
+++ b/src/include/utils/syscache.h
@@ -75,22 +75,22 @@ enum SysCacheIdentifier
PARTRELID,
PROCNAMEARGSNSP,
PROCOID,
+ PUBLICATIONNAME,
+ PUBLICATIONOID,
+ PUBLICATIONREL,
+ PUBLICATIONRELMAP,
RANGETYPE,
RELNAMENSP,
RELOID,
REPLORIGIDENT,
REPLORIGNAME,
- PUBLICATIONOID,
- PUBLICATIONNAME,
- PUBLICATIONREL,
- PUBLICATIONRELMAP,
RULERELNAME,
SEQRELID,
STATEXTNAMENSP,
STATEXTOID,
STATRELATTINH,
- SUBSCRIPTIONOID,
SUBSCRIPTIONNAME,
+ SUBSCRIPTIONOID,
SUBSCRIPTIONRELMAP,
TABLESPACEOID,
TRFOID,
Mark Dilger <hornschnorter@gmail.com> writes:
Just FYI, as of 665d1fad99e7b11678b0d5fa24d2898424243cd6, syscache.h
entries are not in alphabetical order, which violates the coding standard
specified in the comment for these entries. In particular, it is the PUBLICATION
and SUBSCRIPTION entries that are mis-ordered.
Agreed, this is the project convention and we should follow it.
Sorry for my pedantry. Patch attached.
Patch pushed.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers