Typo in xlogfuncs.c [WAS Re: Incorrect mention of pg_xlog_switch() in xlogfuncs.c]
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
Simplifying $subject. There are typos in xlogfuncs.c. So Either
s/pg_xlog_switch/pg_switch_wal
Or
Remove "pg_xlog_switch" from the comments.
Attached patches both ways.
Regards,
Neha
On Sat, May 20, 2017 at 1:08 AM, Neha Khatri <nehakhatri5@gmail.com> wrote:
Show quoted text
While reading some code, noticed that the headers of functions
pg_walfile_name_offset() and pg_walfile_name() incorrecty refer
pg_xlog_switch() since the inception of code in commit 704ddaaa.In PG10 implementation, actual name of the referred function is
pg_switch_wal(). So either refer the correct name in the function
header or remove the other function referral from the function header.
On 5/31/17 19:59, Neha Khatri wrote:
Simplifying $subject. There are typos in xlogfuncs.c. So Either
s/pg_xlog_switch/pg_switch_wal
fixed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers