Fix tab-completion of ALTER SUBSCRIPTION SET PUBLICATION
Hi,
Attached patch for $subject.
With this patch, ALTER SUBSCRIPTION <sub> SET PUBLICATION <pub> [TAB]
completes with "REFRESH" and "SKIP REFRESH".
Specifying either REFRESH or SKIP REFRESH is mandatory after ALTER
SUBSCRIPTION SET PUBLICATION, so i think it's good to add this.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
Attachments:
fix_ALTER_SUB_tab_completion.patchapplication/octet-stream; name=fix_ALTER_SUB_tab_completion.patchDownload+5-0
On 6/6/17 04:17, Masahiko Sawada wrote:
With this patch, ALTER SUBSCRIPTION <sub> SET PUBLICATION <pub> [TAB]
completes with "REFRESH" and "SKIP REFRESH".
Specifying either REFRESH or SKIP REFRESH is mandatory after ALTER
SUBSCRIPTION SET PUBLICATION, so i think it's good to add this.
That syntax does not exist anymore.
You could add support for the new WITH () syntax.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Wed, Jun 7, 2017 at 12:41 PM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
On 6/6/17 04:17, Masahiko Sawada wrote:
With this patch, ALTER SUBSCRIPTION <sub> SET PUBLICATION <pub> [TAB]
completes with "REFRESH" and "SKIP REFRESH".
Specifying either REFRESH or SKIP REFRESH is mandatory after ALTER
SUBSCRIPTION SET PUBLICATION, so i think it's good to add this.That syntax does not exist anymore.
You could add support for the new WITH () syntax.
Sorry, I missed it.
Attached updated version patch adds WITH() syntax.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
Attachments:
fix_ALTER_SUB_tab_completion_v2.patchapplication/octet-stream; name=fix_ALTER_SUB_tab_completion_v2.patchDownload+12-0
On 6/6/17 23:52, Masahiko Sawada wrote:
On Wed, Jun 7, 2017 at 12:41 PM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:On 6/6/17 04:17, Masahiko Sawada wrote:
With this patch, ALTER SUBSCRIPTION <sub> SET PUBLICATION <pub> [TAB]
completes with "REFRESH" and "SKIP REFRESH".
Specifying either REFRESH or SKIP REFRESH is mandatory after ALTER
SUBSCRIPTION SET PUBLICATION, so i think it's good to add this.That syntax does not exist anymore.
You could add support for the new WITH () syntax.
Sorry, I missed it.
Attached updated version patch adds WITH() syntax.
Committed, with the addition of the copy_data option.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers