Fix tab-completion of ALTER SUBSCRIPTION SET PUBLICATION
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t36864psql -h localhost -U postgresBuilt from patchset v3 (message #3), July 28, 2026 at 06:28 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t36864_3 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t36864_3 && git checkout t36864_3Patchset v3 (message #3) is on t36864_3
Hi,
Attached patch for $subject.
With this patch, ALTER SUBSCRIPTION <sub> SET PUBLICATION <pub> [TAB]
completes with "REFRESH" and "SKIP REFRESH".
Specifying either REFRESH or SKIP REFRESH is mandatory after ALTER
SUBSCRIPTION SET PUBLICATION, so i think it's good to add this.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
Attachments:
fix_ALTER_SUB_tab_completion.patchapplication/octet-stream; name=fix_ALTER_SUB_tab_completion.patchDownload+5-0
On 6/6/17 04:17, Masahiko Sawada wrote:
With this patch, ALTER SUBSCRIPTION <sub> SET PUBLICATION <pub> [TAB]
completes with "REFRESH" and "SKIP REFRESH".
Specifying either REFRESH or SKIP REFRESH is mandatory after ALTER
SUBSCRIPTION SET PUBLICATION, so i think it's good to add this.
That syntax does not exist anymore.
You could add support for the new WITH () syntax.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Wed, Jun 7, 2017 at 12:41 PM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
On 6/6/17 04:17, Masahiko Sawada wrote:
With this patch, ALTER SUBSCRIPTION <sub> SET PUBLICATION <pub> [TAB]
completes with "REFRESH" and "SKIP REFRESH".
Specifying either REFRESH or SKIP REFRESH is mandatory after ALTER
SUBSCRIPTION SET PUBLICATION, so i think it's good to add this.That syntax does not exist anymore.
You could add support for the new WITH () syntax.
Sorry, I missed it.
Attached updated version patch adds WITH() syntax.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
On 6/6/17 23:52, Masahiko Sawada wrote:
On Wed, Jun 7, 2017 at 12:41 PM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:On 6/6/17 04:17, Masahiko Sawada wrote:
With this patch, ALTER SUBSCRIPTION <sub> SET PUBLICATION <pub> [TAB]
completes with "REFRESH" and "SKIP REFRESH".
Specifying either REFRESH or SKIP REFRESH is mandatory after ALTER
SUBSCRIPTION SET PUBLICATION, so i think it's good to add this.That syntax does not exist anymore.
You could add support for the new WITH () syntax.
Sorry, I missed it.
Attached updated version patch adds WITH() syntax.
Committed, with the addition of the copy_data option.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers