CI
Applieswon't retry10y behind master
Buildtests failed1m 33s / 4m 57s
Tests332 / 411
  • regress/postgres_fdw
  • regress/prepared_xacts
  • regress/brin
  • regress/gin
  • regress/gist
  • regress/spgist
  • regress/privileges
  • regress/init_privs
  • regress/security_label
  • regress/collate
+69 more
GitHub runGitHub branchCI history
Participants
Tatsuo Ishii
Tatsuo Ishii
Yugo Nagata
Yugo Nagata
Amit Langote
Amit Langote
Attachments
Download Latest Patchset
+1-1
Show all attachments
Show all patchsets
Thread Outline
#1Yugo NagataYugo Nagata
Jun 12, 2017
#2Tatsuo Ishii↳Tatsuo Ishiito Yugo Nagata (#1)
Jun 12, 2017
#3Amit Langote↳Amit Langoteto Tatsuo Ishii (#2)
Jun 12, 2017
#4Tatsuo Ishii↳Tatsuo Ishiito Amit Langote (#3)
Jun 12, 2017

documentation typo in ALTER TABLE example

Started by Yugo Nagataover 9 years ago4 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrytests failedCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t36897
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 28, 2026 at 06:27 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t36897_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t36897_1 && git checkout t36897_1

Patchset v1 (message #1) is on t36897_1

Jump to latest
#1Yugo Nagata
Yugo Nagata
nagata@sraoss.co.jp

Hi,

Attached is a simple patch to fix a documentation typo in
the ALTER TABLE example.

Regards,

--
Yugo Nagata <nagata@sraoss.co.jp>

Attachments:

t36897_1
alter_table_doc_typo.patchtext/x-diff; name=alter_table_doc_typo.patchDownload+1-1
#2Tatsuo Ishii
Tatsuo Ishii
ishii@postgresql.org
In reply to: Yugo Nagata (#1)
Re: documentation typo in ALTER TABLE example

Hi,

Attached is a simple patch to fix a documentation typo in
the ALTER TABLE example.

Or the original author's intention might have been something like
this:

--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -1399,7 +1399,7 @@ ALTER TABLE cities
    Detach a partition from partitioned table:
 <programlisting>
 ALTER TABLE cities
-    DETACH PARTITION measurement_y2015m12;
+    DETACH PARTITION cities_ab;

Amit Langote, which one was your intention?
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Amit Langote
Amit Langote
Langote_Amit_f8@lab.ntt.co.jp
In reply to: Tatsuo Ishii (#2)
Re: documentation typo in ALTER TABLE example

On 2017/06/12 11:01, Tatsuo Ishii wrote:

Hi,

Attached is a simple patch to fix a documentation typo in
the ALTER TABLE example.

Or the original author's intention might have been something like
this:

--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -1399,7 +1399,7 @@ ALTER TABLE cities
Detach a partition from partitioned table:
<programlisting>
ALTER TABLE cities
-    DETACH PARTITION measurement_y2015m12;
+    DETACH PARTITION cities_ab;

Amit Langote, which one was your intention?

I wanted to show DETACH PARTITION command's usage with a range partitioned
table (detaching the "oldest" partition).

So, we should apply Nagata-san's patch.

Thanks,
Amit

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Tatsuo Ishii
Tatsuo Ishii
ishii@postgresql.org
In reply to: Amit Langote (#3)
Re: documentation typo in ALTER TABLE example

Amit Langote, which one was your intention?

I wanted to show DETACH PARTITION command's usage with a range partitioned
table (detaching the "oldest" partition).

So, we should apply Nagata-san's patch.

Thank you for the confirmation. I have pushed the patch.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

← Back to Topics