documentation typo in ALTER TABLE example

Started by Yugo Nagataover 8 years ago4 messages

Yugo Nagata

nagata@sraoss.co.jp

over 8 years ago

1 attachment(s)

Hi,

Attached is a simple patch to fix a documentation typo in
the ALTER TABLE example.

Regards,

--
Yugo Nagata <nagata@sraoss.co.jp>

Attachments:

alter_table_doc_typo.patchtext/x-diff; name=alter_table_doc_typo.patchDownload

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index 56ea830..4c61c44 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -1398,7 +1398,7 @@ ALTER TABLE cities
   <para>
    Detach a partition from partitioned table:
 <programlisting>
-ALTER TABLE cities
+ALTER TABLE measurement
     DETACH PARTITION measurement_y2015m12;
 </programlisting></para>

Tatsuo Ishii

ishii@sraoss.co.jp

over 8 years ago

In reply to: Yugo Nagata (#1)

Re: documentation typo in ALTER TABLE example

Hi,

Attached is a simple patch to fix a documentation typo in
the ALTER TABLE example.

Or the original author's intention might have been something like
this:

--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -1399,7 +1399,7 @@ ALTER TABLE cities
    Detach a partition from partitioned table:
 <programlisting>
 ALTER TABLE cities
-    DETACH PARTITION measurement_y2015m12;
+    DETACH PARTITION cities_ab;

Amit Langote, which one was your intention?
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Amit Langote

Langote_Amit_f8@lab.ntt.co.jp

over 8 years ago

In reply to: Tatsuo Ishii (#2)

Re: documentation typo in ALTER TABLE example

On 2017/06/12 11:01, Tatsuo Ishii wrote:

Hi,

Attached is a simple patch to fix a documentation typo in
the ALTER TABLE example.

Or the original author's intention might have been something like
this:
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -1399,7 +1399,7 @@ ALTER TABLE cities
Detach a partition from partitioned table:
<programlisting>
ALTER TABLE cities
-    DETACH PARTITION measurement_y2015m12;
+    DETACH PARTITION cities_ab;
Amit Langote, which one was your intention?

I wanted to show DETACH PARTITION command's usage with a range partitioned
table (detaching the "oldest" partition).

So, we should apply Nagata-san's patch.

Thanks,
Amit

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Tatsuo Ishii

ishii@sraoss.co.jp

over 8 years ago

In reply to: Amit Langote (#3)

Re: documentation typo in ALTER TABLE example

Amit Langote, which one was your intention?

I wanted to show DETACH PARTITION command's usage with a range partitioned
table (detaching the "oldest" partition).

So, we should apply Nagata-san's patch.

Thank you for the confirmation. I have pushed the patch.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers