improve release-note for pg_current_logfile()

Started by Yugo Nagataover 8 years ago3 messages

Yugo Nagata

nagata@sraoss.co.jp

over 8 years ago

1 attachment(s)

Hi,

When I am reading the PG 10 release-notes, I found the following item.

Add function pg_current_logfile() to read syslog's current stderr and csvlog output file names (Gilles Darold)

This confused me because "syslog" is one of method for logging as well
as stderr and csvlog. I guess it is intended syslogger, but I think that
"logging collector" is more convenient for users because this is used in
the pg_current_logfile() documentation.

pg_current_logfile returns, as text, the path of the log file(s) currently in use by the logging collector.

Attached is a patch to fix it.

Regards,

--
Yugo Nagata <nagata@sraoss.co.jp>

Attachments:

release_note_pg_current_logfile.pachapplication/octet-stream; name=release_note_pg_current_logfile.pachDownload

diff --git a/doc/src/sgml/release-10.sgml b/doc/src/sgml/release-10.sgml
index b10086bd..54710fe 100644
--- a/doc/src/sgml/release-10.sgml
+++ b/doc/src/sgml/release-10.sgml
@@ -949,7 +949,7 @@
         <para>
          Add function <link
          linkend="functions-info-session-table"><function>pg_current_logfile()</></>
-         to read syslog's current stderr and csvlog output file names
+         to read logging collector's current stderr and csvlog output file names
          (Gilles Darold)
         </para>
        </listitem>

Tatsuo Ishii

ishii@sraoss.co.jp

over 8 years ago

In reply to: Yugo Nagata (#1)

Re: improve release-note for pg_current_logfile()

Add function pg_current_logfile() to read syslog's current stderr and csvlog output file names (Gilles Darold)

This confused me because "syslog" is one of method for logging as well
as stderr and csvlog. I guess it is intended syslogger, but I think that
"logging collector" is more convenient for users because this is used in
the pg_current_logfile() documentation.

His proposal is changing the line above to:

Add function pg_current_logfile() to read logging collector's current stderr and csvlog output file names (Gilles Darold)

Looks reasonable fix to me. If there's no objection, I will commit
this.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Tatsuo Ishii

ishii@sraoss.co.jp

over 8 years ago

In reply to: Tatsuo Ishii (#2)

Re: improve release-note for pg_current_logfile()

Add function pg_current_logfile() to read syslog's current stderr and csvlog output file names (Gilles Darold)

This confused me because "syslog" is one of method for logging as well
as stderr and csvlog. I guess it is intended syslogger, but I think that
"logging collector" is more convenient for users because this is used in
the pg_current_logfile() documentation.

His proposal is changing the line above to:

Add function pg_current_logfile() to read logging collector's current stderr and csvlog output file names (Gilles Darold)

Looks reasonable fix to me. If there's no objection, I will commit
this.

Done.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers