Incorrect comment in 001_ssltests.pl
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t36942psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 28, 2026 at 06:16 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t36942_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t36942_1 && git checkout t36942_1Patchset v1 (message #1) is on t36942_1
Hi all,
I have noticed the following thing:
--- a/src/test/ssl/t/001_ssltests.pl
+++ b/src/test/ssl/t/001_ssltests.pl
@@ -34,8 +34,6 @@ sub run_test_psql
# The first argument is a (part of a) connection string, and it's also printed
# out as the test case name. It is appended to $common_connstr global variable,
# which also contains a libpq connection string.
-#
-# The second argument is a hostname to connect to.
sub test_connect_ok
{
my $connstr = $_[0]But test_connect_ok and test_connect_fails do not have a second
argument as the hostname is appended directly into $common_connstr.
(I am thinking as well that run_test_psql, test_connect_ok and
test_connect_fails ought to be moved to ServerSetup.pm so as other SSL
tests can take advantage of them, but that's another story for another
day.)
Thanks,
--
Michael
On Sat, Jun 17, 2017 at 1:53 AM, Michael Paquier <michael.paquier@gmail.com>
wrote:
Hi all,
I have noticed the following thing: --- a/src/test/ssl/t/001_ssltests.pl +++ b/src/test/ssl/t/001_ssltests.pl @@ -34,8 +34,6 @@ sub run_test_psql # The first argument is a (part of a) connection string, and it's also printed # out as the test case name. It is appended to $common_connstr global variable, # which also contains a libpq connection string. -# -# The second argument is a hostname to connect to. sub test_connect_ok { my $connstr = $_[0]But test_connect_ok and test_connect_fails do not have a second
argument as the hostname is appended directly into $common_connstr.
One could argue that the first sentences should just read "the argument"
once the second one isn't referred, but I can't get too excited about that.
Thus, patch applied as-is - thanks!
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
On Sat, Jun 17, 2017 at 5:20 PM, Magnus Hagander <magnus@hagander.net> wrote:
One could argue that the first sentences should just read "the argument"
once the second one isn't referred, but I can't get too excited about that.
Thus, patch applied as-is - thanks!
Thanks.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers