Missing comment for ResultRelInfo in execnodes.h

Started by Etsuro Fujitaover 9 years ago4 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t36962
psql -h localhost -U postgres

Built from patchset v2 (message #2), July 28, 2026 at 06:15 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t36962_2 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t36962_2 && git checkout t36962_2

Patchset v2 (message #2) is on t36962_2

Jump to latest
#1Etsuro Fujita
fujita.etsuro@lab.ntt.co.jp

Here is a small patch to add a comment on its new member PartitionRoot.

Best regards,
Etsuro Fujita

Attachments:

ResultRelInfo-commnet.patchtext/plain; charset=UTF-8; name=ResultRelInfo-commnet.patchDownload+1-0
#2Peter Eisentraut
peter_e@gmx.net
In reply to: Etsuro Fujita (#1)
Re: Missing comment for ResultRelInfo in execnodes.h

On 6/20/17 05:50, Etsuro Fujita wrote:

Here is a small patch to add a comment on its new member PartitionRoot.

The existing comment style is kind of unusual. How about the attached
to clean it up a bit?

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachments:

t36962_2
0001-Reformat-comments-about-ResultRelInfo.patchtext/plain; charset=UTF-8; name=0001-Reformat-comments-about-ResultRelInfo.patch; x-mac-creator=0; x-mac-type=0Download+50-31
#3Etsuro Fujita
fujita.etsuro@lab.ntt.co.jp
In reply to: Peter Eisentraut (#2)
Re: Missing comment for ResultRelInfo in execnodes.h

On 2017/06/21 3:30, Peter Eisentraut wrote:

On 6/20/17 05:50, Etsuro Fujita wrote:

Here is a small patch to add a comment on its new member PartitionRoot.

The existing comment style is kind of unusual. How about the attached
to clean it up a bit?

+1 for that change.

Best regards,
Etsuro Fujita

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Peter Eisentraut
peter_e@gmx.net
In reply to: Etsuro Fujita (#3)
Re: Missing comment for ResultRelInfo in execnodes.h

On 6/20/17 22:37, Etsuro Fujita wrote:

On 2017/06/21 3:30, Peter Eisentraut wrote:

On 6/20/17 05:50, Etsuro Fujita wrote:

Here is a small patch to add a comment on its new member PartitionRoot.

The existing comment style is kind of unusual. How about the attached
to clean it up a bit?

+1 for that change.

committed

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers