pg_bsd_indent 2.0 is available from git.postgresql.org

Started by Tom Laneover 8 years ago13 messages

tgl@sss.pgh.pa.us

over 8 years ago

I've set up a repo on our git server for the new improved version
of pg_bsd_indent. Please test it for portability to your favorite
platform(s) by doing

git clone https://git.postgresql.org/git/pg_bsd_indent.git
cd pg_bsd_indent
make -s all
make check

Note you will need a PG installation in your PATH; see
README.pg_bsd_indent for details.

There's no Windows support yet, and I won't be writing that,
but I hope someone else will.

BTW, HEAD's version of pgindent doesn't play with this yet, so
don't overwrite your old copy of pg_bsd_indent quite yet.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Andrew Dunstan

andrew.dunstan@2ndquadrant.com

over 8 years ago

In reply to: Tom Lane (#1)

Re: pg_bsd_indent 2.0 is available from git.postgresql.org

On 06/20/2017 04:17 PM, Tom Lane wrote:

I've set up a repo on our git server for the new improved version
of pg_bsd_indent. Please test it for portability to your favorite
platform(s) by doing

git clone https://git.postgresql.org/git/pg_bsd_indent.git
cd pg_bsd_indent
make -s all
make check

Note you will need a PG installation in your PATH; see
README.pg_bsd_indent for details.

There's no Windows support yet, and I won't be writing that,
but I hope someone else will.

What extra support do you think it needs? I have built it on Cygwin
without touching a line of code, will probably be able to to the same on
Mingw.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Tom Lane

tgl@sss.pgh.pa.us

over 8 years ago

In reply to: Andrew Dunstan (#2)

Re: pg_bsd_indent 2.0 is available from git.postgresql.org

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:

On 06/20/2017 04:17 PM, Tom Lane wrote:

There's no Windows support yet, and I won't be writing that,
but I hope someone else will.

What extra support do you think it needs? I have built it on Cygwin
without touching a line of code, will probably be able to to the same on
Mingw.

Yeah, I thought it would work fine with Makefile-using Windows toolchains.
But people who use MSVC need something else, no?

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Michael Paquier

michael.paquier@gmail.com

over 8 years ago

In reply to: Tom Lane (#3)

Re: pg_bsd_indent 2.0 is available from git.postgresql.org

On Wed, Jun 21, 2017 at 8:43 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Yeah, I thought it would work fine with Makefile-using Windows toolchains.
But people who use MSVC need something else, no?

Are there that many anyway who care? Personally I already fallback to
Linux when it comes to indentation of Windows patches.
--
Michael

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Tom Lane

tgl@sss.pgh.pa.us

over 8 years ago

In reply to: Michael Paquier (#4)

Re: pg_bsd_indent 2.0 is available from git.postgresql.org

Michael Paquier <michael.paquier@gmail.com> writes:

On Wed, Jun 21, 2017 at 8:43 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Yeah, I thought it would work fine with Makefile-using Windows toolchains.
But people who use MSVC need something else, no?

Are there that many anyway who care?

Well, *I* don't care, but I thought we wanted to support Windows-using
developers as reasonably first-class citizens.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Andrew Dunstan

andrew.dunstan@2ndquadrant.com

over 8 years ago

In reply to: Tom Lane (#5)

Re: pg_bsd_indent 2.0 is available from git.postgresql.org

On 06/20/2017 08:30 PM, Tom Lane wrote:

Michael Paquier <michael.paquier@gmail.com> writes:

On Wed, Jun 21, 2017 at 8:43 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Yeah, I thought it would work fine with Makefile-using Windows toolchains.
But people who use MSVC need something else, no?

Are there that many anyway who care?

Well, *I* don't care, but I thought we wanted to support Windows-using
developers as reasonably first-class citizens.

I imagine we can rig up something fairly simple based on Craig Ringer's
recent work in building extensions on Windows using cmake.

I'll take a look when I get a chance, but I don't think it's a high
priority.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Andrew Dunstan

andrew.dunstan@2ndquadrant.com

over 8 years ago

In reply to: Andrew Dunstan (#6)

Re: pg_bsd_indent 2.0 is available from git.postgresql.org

On 06/21/2017 08:20 AM, Andrew Dunstan wrote:

On 06/20/2017 08:30 PM, Tom Lane wrote:

Michael Paquier <michael.paquier@gmail.com> writes:

On Wed, Jun 21, 2017 at 8:43 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Yeah, I thought it would work fine with Makefile-using Windows toolchains.
But people who use MSVC need something else, no?

Are there that many anyway who care?

Well, *I* don't care, but I thought we wanted to support Windows-using
developers as reasonably first-class citizens.

I imagine we can rig up something fairly simple based on Craig Ringer's
recent work in building extensions on Windows using cmake.

I'll take a look when I get a chance, but I don't think it's a high
priority.

Unfortunately this seems precluded by the use of the non-standard
"err.h". It looks like that will trip us up on mingw also.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Tom Lane

tgl@sss.pgh.pa.us

over 8 years ago

In reply to: Andrew Dunstan (#7)

Re: pg_bsd_indent 2.0 is available from git.postgresql.org

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:

Unfortunately this seems precluded by the use of the non-standard
"err.h". It looks like that will trip us up on mingw also.

Hm, why? Doesn't the -I search path get the right thing?

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Andres Freund

andres@anarazel.de

over 8 years ago

In reply to: Tom Lane (#5)

Re: pg_bsd_indent 2.0 is available from git.postgresql.org

On 2017-06-20 20:30:34 -0400, Tom Lane wrote:

Michael Paquier <michael.paquier@gmail.com> writes:

On Wed, Jun 21, 2017 at 8:43 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Yeah, I thought it would work fine with Makefile-using Windows toolchains.
But people who use MSVC need something else, no?

Are there that many anyway who care?

Well, *I* don't care, but I thought we wanted to support Windows-using
developers as reasonably first-class citizens.

The old one didn't have windows support either, right?

- Andres

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#10

Tom Lane

tgl@sss.pgh.pa.us

over 8 years ago

In reply to: Andres Freund (#9)

Re: pg_bsd_indent 2.0 is available from git.postgresql.org

Andres Freund <andres@anarazel.de> writes:

On 2017-06-20 20:30:34 -0400, Tom Lane wrote:

Well, *I* don't care, but I thought we wanted to support Windows-using
developers as reasonably first-class citizens.

The old one didn't have windows support either, right?

Not that I was aware of, but a large part of the point here is to
make things better than they were before.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#11

Andrew Dunstan

andrew.dunstan@2ndquadrant.com

over 8 years ago

In reply to: Tom Lane (#8)

Re: pg_bsd_indent 2.0 is available from git.postgresql.org

On 06/21/2017 11:30 AM, Tom Lane wrote:

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:

Unfortunately this seems precluded by the use of the non-standard
"err.h". It looks like that will trip us up on mingw also.

Hm, why? Doesn't the -I search path get the right thing?

The file isn't present at all. On my Linux workstation "man errx" says:

CONFORMING TO
These functions are nonstandard BSD extensions.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#12

Tom Lane

tgl@sss.pgh.pa.us

over 8 years ago

In reply to: Andrew Dunstan (#11)

Re: pg_bsd_indent 2.0 is available from git.postgresql.org

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:

On 06/21/2017 11:30 AM, Tom Lane wrote:

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:

Unfortunately this seems precluded by the use of the non-standard
"err.h". It looks like that will trip us up on mingw also.

Hm, why? Doesn't the -I search path get the right thing?

The file isn't present at all.

Uh, what? It's in the repo.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#13

Andrew Dunstan

andrew.dunstan@2ndquadrant.com

over 8 years ago

In reply to: Tom Lane (#12)

Re: pg_bsd_indent 2.0 is available from git.postgresql.org

On 06/21/2017 02:25 PM, Tom Lane wrote:

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:

On 06/21/2017 11:30 AM, Tom Lane wrote:

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:

Unfortunately this seems precluded by the use of the non-standard
"err.h". It looks like that will trip us up on mingw also.

Hm, why? Doesn't the -I search path get the right thing?

The file isn't present at all.

Uh, what? It's in the repo.

Oh, sorry, my bad, brain fade while multitasking.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers