Fix comment in xlog.c

Started by Amit Langoteover 8 years ago3 messages

Langote_Amit_f8@lab.ntt.co.jp

over 8 years ago

1 attachment(s)

Attached a patch for $SUBJECT.

- * If RecPtr is not NULL, try to read a record at that position.  Otherwise
+ * If RecPtr is valid, try to read a record at that position.  Otherwise

Commit 4d6d425ab8d addressed the comment above XLogReadRecord() in
xlogreader.c, but missed the same above ReadRecord() in xlog.c.

Backpatchable to 9.3, I'd think.

Thanks,
Amit

Attachments:

xlog-comment-fix.patchtext/plain; charset=UTF-8; name=xlog-comment-fix.patchDownload

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 70d2570dc2..197e9cc726 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -4132,7 +4132,7 @@ CleanupBackupHistory(void)
 /*
  * Attempt to read an XLOG record.
  *
- * If RecPtr is not NULL, try to read a record at that position.  Otherwise
+ * If RecPtr is valid, try to read a record at that position.  Otherwise
  * try to read a record just after the last one previously read.
  *
  * If no valid record is available, returns NULL, or fails if emode is PANIC.

Alvaro Herrera

alvherre@2ndquadrant.com

over 8 years ago

In reply to: Amit Langote (#1)

Re: Fix comment in xlog.c

Amit Langote wrote:

Attached a patch for $SUBJECT.
- * If RecPtr is not NULL, try to read a record at that position.  Otherwise
+ * If RecPtr is valid, try to read a record at that position.  Otherwise
Commit 4d6d425ab8d addressed the comment above XLogReadRecord() in
xlogreader.c, but missed the same above ReadRecord() in xlog.c.

Backpatchable to 9.3, I'd think.

Yeah, fixed, thanks.

--
ï¿½lvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Amit Langote

Langote_Amit_f8@lab.ntt.co.jp

over 8 years ago

In reply to: Alvaro Herrera (#2)

Re: Fix comment in xlog.c

On 2017/06/23 5:44, Alvaro Herrera wrote:

Amit Langote wrote:
Attached a patch for $SUBJECT.
- * If RecPtr is not NULL, try to read a record at that position.  Otherwise
+ * If RecPtr is valid, try to read a record at that position.  Otherwise
Commit 4d6d425ab8d addressed the comment above XLogReadRecord() in
xlogreader.c, but missed the same above ReadRecord() in xlog.c.

Backpatchable to 9.3, I'd think.
Yeah, fixed, thanks.

And thanks too.

Regards,
Amit

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers