A mistake in a comment

Started by Victor Drobnyalmost 9 years ago2 messageshackers
Jump to latest
#1Victor Drobny
v.drobny@postgrespro.ru

Hello,

I believe that I have found a mistake in a comment to
parse_phrase_operator function. The comment has the following line:
a <X> b (distance is no greater than X)
which is not. According to documentation and practical results, this
line should me changed on something like:
a <X> b (distance is equal to X)

Patch in the attachments fixes the issue.

Thank you for attention!

Best,
Victor

Attachments:

comment_patch.difftext/x-diff; name=comment_patch.diffDownload+1-1
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Victor Drobny (#1)
Re: A mistake in a comment

Victor Drobny <v.drobny@postgrespro.ru> writes:

I believe that I have found a mistake in a comment to
parse_phrase_operator function. The comment has the following line:
a <X> b (distance is no greater than X)
which is not. According to documentation and practical results, this
line should me changed on something like:
a <X> b (distance is equal to X)

Ah, this comment got missed when we changed the definition of <N>.

Patch in the attachments fixes the issue.

Will apply, thanks. Looks to me like there's an outright bug here
as well: if errno happened to already be ERANGE when we reach the
strtol() call, the code will incorrectly report an error.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers