Incorrect mentions to pg_xlog in walmethods.c/h
Hi all,
I have noticed $subject. A patch is attached. Those comments are not
completely wrong either as pg_basebackup can generate pg_xlog as well,
still I would recommend to just mention "pg_wal".
Thanks,
--
Michael
Attachments:
walmethods-comments.patchapplication/octet-stream; name=walmethods-comments.patchDownload
diff --git a/src/bin/pg_basebackup/walmethods.c b/src/bin/pg_basebackup/walmethods.c
index 5fe02dee72..06d8ab5bc2 100644
--- a/src/bin/pg_basebackup/walmethods.c
+++ b/src/bin/pg_basebackup/walmethods.c
@@ -31,7 +31,7 @@
#define ZLIB_OUT_SIZE 4096
/*-------------------------------------------------------------------------
- * WalDirectoryMethod - write wal to a directory looking like pg_xlog
+ * WalDirectoryMethod - write wal to a directory looking like pg_wal
*-------------------------------------------------------------------------
*/
@@ -375,7 +375,7 @@ FreeWalDirectoryMethod(void)
/*-------------------------------------------------------------------------
- * WalTarMethod - write wal to a tar file containing pg_xlog contents
+ * WalTarMethod - write wal to a tar file containing pg_wal contents
*-------------------------------------------------------------------------
*/
diff --git a/src/bin/pg_basebackup/walmethods.h b/src/bin/pg_basebackup/walmethods.h
index f9d2f66d84..3fdc947ab9 100644
--- a/src/bin/pg_basebackup/walmethods.h
+++ b/src/bin/pg_basebackup/walmethods.h
@@ -80,8 +80,8 @@ struct WalWriteMethod
/*
* Available WAL methods:
- * - WalDirectoryMethod - write WAL to regular files in a standard pg_xlog
- * - TarDirectoryMethod - write WAL to a tarfile corresponding to pg_xlog
+ * - WalDirectoryMethod - write WAL to regular files in a standard pg_wal
+ * - TarDirectoryMethod - write WAL to a tarfile corresponding to pg_wal
* (only implements the methods required for pg_basebackup,
* not all those required for pg_receivewal)
*/
On 6/27/17 01:26, Michael Paquier wrote:
I have noticed $subject. A patch is attached. Those comments are not
completely wrong either as pg_basebackup can generate pg_xlog as well,
still I would recommend to just mention "pg_wal".
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Sat, Jul 1, 2017 at 3:41 AM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
On 6/27/17 01:26, Michael Paquier wrote:
I have noticed $subject. A patch is attached. Those comments are not
completely wrong either as pg_basebackup can generate pg_xlog as well,
still I would recommend to just mention "pg_wal".committed
Thanks.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation: not tested
This commit only affects comments, so I'm confident it doesn't break code, though I did not run the tests.
I understand that the pg_xlog directory was renamed to pg_wal (confirmed that this is in the changelog too), so the comment changes seem correct.
I am marking this Ready for Committer.
The new status of this patch is: Ready for Committer
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Wed, Jul 5, 2017 at 2:29 PM, Ryan Murphy <ryanfmurphy@gmail.com> wrote:
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation: not testedThis commit only affects comments, so I'm confident it doesn't break code, though I did not run the tests.
I understand that the pg_xlog directory was renamed to pg_wal (confirmed that this is in the changelog too), so the comment changes seem correct.
I am marking this Ready for Committer.
The new status of this patch is: Ready for Committer
Thanks for the update. This has been already committed though as of 4260c05.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers