Incorrect mentions to pg_xlog in walmethods.c/h

On 6/27/17 01:26, Michael Paquier wrote:

I have noticed $subject. A patch is attached. Those comments are not
completely wrong either as pg_basebackup can generate pg_xlog as well,
still I would recommend to just mention "pg_wal".

committed

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On Sat, Jul 1, 2017 at 3:41 AM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:

On 6/27/17 01:26, Michael Paquier wrote:

I have noticed $subject. A patch is attached. Those comments are not
completely wrong either as pg_basebackup can generate pg_xlog as well,
still I would recommend to just mention "pg_wal".

committed

Thanks.
--
Michael

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation: not tested

This commit only affects comments, so I'm confident it doesn't break code, though I did not run the tests.

I understand that the pg_xlog directory was renamed to pg_wal (confirmed that this is in the changelog too), so the comment changes seem correct.

I am marking this Ready for Committer.

The new status of this patch is: Ready for Committer

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On Wed, Jul 5, 2017 at 2:29 PM, Ryan Murphy <ryanfmurphy@gmail.com> wrote:

The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation: not tested

This commit only affects comments, so I'm confident it doesn't break code, though I did not run the tests.

I understand that the pg_xlog directory was renamed to pg_wal (confirmed that this is in the changelog too), so the comment changes seem correct.

I am marking this Ready for Committer.

The new status of this patch is: Ready for Committer

Thanks for the update. This has been already committed though as of 4260c05.
--
Michael

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers