Misleading comment in slru.h
Hi hackers,
As mentioned in another thread[1]/messages/by-id/CAEepm=1UdqnmHTikNBsBYsSDuk3nc9rXFPbeWYrbA2iM6K9q2w@mail.gmail.com, slru.h says:
* Note: slru.c currently assumes that segment file names will be four hex
* digits. This sets a lower bound on the segment size (64K transactions
* for 32-bit TransactionIds).
That comment is out of date: commit 638cf09e extended SLRUs to support
5 character names to support pg_multixact and commit 73c986ad extended
support to 6 character SLRU file names for pg_commit_ts.
Should we just remove that comment?
[1]: /messages/by-id/CAEepm=1UdqnmHTikNBsBYsSDuk3nc9rXFPbeWYrbA2iM6K9q2w@mail.gmail.com
--
Thomas Munro
http://www.enterprisedb.com
Attachments:
remove-misleading-comment.patchapplication/octet-stream; name=remove-misleading-comment.patchDownload
diff --git a/src/include/access/slru.h b/src/include/access/slru.h
index f1b4d6cc9d..d829a6fab4 100644
--- a/src/include/access/slru.h
+++ b/src/include/access/slru.h
@@ -29,10 +29,6 @@
* 0xFFFFFFFF/xxxx_XACTS_PER_PAGE/SLRU_PAGES_PER_SEGMENT. We need
* take no explicit notice of that fact in slru.c, except when comparing
* segment and page numbers in SimpleLruTruncate (see PagePrecedes()).
- *
- * Note: slru.c currently assumes that segment file names will be four hex
- * digits. This sets a lower bound on the segment size (64K transactions
- * for 32-bit TransactionIds).
*/
#define SLRU_PAGES_PER_SEGMENT 32
On 6/27/17 01:43, Thomas Munro wrote:
As mentioned in another thread[1], slru.h says:
* Note: slru.c currently assumes that segment file names will be four hex
* digits. This sets a lower bound on the segment size (64K transactions
* for 32-bit TransactionIds).That comment is out of date: commit 638cf09e extended SLRUs to support
5 character names to support pg_multixact and commit 73c986ad extended
support to 6 character SLRU file names for pg_commit_ts.Should we just remove that comment?
done
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers