Misleading comment in slru.h
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t37016psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 28, 2026 at 06:04 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t37016_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t37016_1 && git checkout t37016_1Patchset v1 (message #1) is on t37016_1
Hi hackers,
As mentioned in another thread[1]/messages/by-id/CAEepm=1UdqnmHTikNBsBYsSDuk3nc9rXFPbeWYrbA2iM6K9q2w@mail.gmail.com, slru.h says:
* Note: slru.c currently assumes that segment file names will be four hex
* digits. This sets a lower bound on the segment size (64K transactions
* for 32-bit TransactionIds).
That comment is out of date: commit 638cf09e extended SLRUs to support
5 character names to support pg_multixact and commit 73c986ad extended
support to 6 character SLRU file names for pg_commit_ts.
Should we just remove that comment?
[1]: /messages/by-id/CAEepm=1UdqnmHTikNBsBYsSDuk3nc9rXFPbeWYrbA2iM6K9q2w@mail.gmail.com
--
Thomas Munro
http://www.enterprisedb.com
On 6/27/17 01:43, Thomas Munro wrote:
As mentioned in another thread[1], slru.h says:
* Note: slru.c currently assumes that segment file names will be four hex
* digits. This sets a lower bound on the segment size (64K transactions
* for 32-bit TransactionIds).That comment is out of date: commit 638cf09e extended SLRUs to support
5 character names to support pg_multixact and commit 73c986ad extended
support to 6 character SLRU file names for pg_commit_ts.Should we just remove that comment?
done
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers