Another comment typo in execMain.c

Started by Etsuro Fujitaover 8 years ago3 messages
#1Etsuro Fujita
fujita.etsuro@lab.ntt.co.jp
1 attachment(s)

Here is a comment in ExecFindPartition() in execMain.c:

/*
* First check the root table's partition constraint, if any. No
point in
* routing the tuple it if it doesn't belong in the root table itself.
*/

I think that in the second sentence "it" just before "if" is a typo.
Attached is a small patch for fixing that.

Best regards,
Etsuro Fujita

Attachments:

ExecFindPartition-comment-typo.patchtext/plain; charset=UTF-8; name=ExecFindPartition-comment-typo.patchDownload
diff --git a/src/backend/executor/execMain.c b/src/backend/executor/execMain.c
index 0f08283..06b467b 100644
--- a/src/backend/executor/execMain.c
+++ b/src/backend/executor/execMain.c
@@ -3310,7 +3310,7 @@ ExecFindPartition(ResultRelInfo *resultRelInfo, PartitionDispatch *pd,
 
 	/*
 	 * First check the root table's partition constraint, if any.  No point in
-	 * routing the tuple it if it doesn't belong in the root table itself.
+	 * routing the tuple if it doesn't belong in the root table itself.
 	 */
 	if (resultRelInfo->ri_PartitionCheck)
 		ExecPartitionCheck(resultRelInfo, slot, estate);
#2Peter Eisentraut
peter.eisentraut@2ndquadrant.com
In reply to: Etsuro Fujita (#1)
Re: Another comment typo in execMain.c

On 7/6/17 03:23, Etsuro Fujita wrote:

Here is a comment in ExecFindPartition() in execMain.c:

/*
* First check the root table's partition constraint, if any. No
point in
* routing the tuple it if it doesn't belong in the root table itself.
*/

I think that in the second sentence "it" just before "if" is a typo.
Attached is a small patch for fixing that.

fixed

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Etsuro Fujita
fujita.etsuro@lab.ntt.co.jp
In reply to: Peter Eisentraut (#2)
Re: Another comment typo in execMain.c

On 2017/08/01 6:09, Peter Eisentraut wrote:

On 7/6/17 03:23, Etsuro Fujita wrote:

Here is a comment in ExecFindPartition() in execMain.c:

/*
* First check the root table's partition constraint, if any. No
point in
* routing the tuple it if it doesn't belong in the root table itself.
*/

I think that in the second sentence "it" just before "if" is a typo.
Attached is a small patch for fixing that.

fixed

Thanks!

Best regards,
Etsuro Fujita

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers