Another comment typo in execMain.c
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t37060psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 28, 2026 at 05:55 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t37060_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t37060_1 && git checkout t37060_1Patchset v1 (message #1) is on t37060_1
Here is a comment in ExecFindPartition() in execMain.c:
/*
* First check the root table's partition constraint, if any. No
point in
* routing the tuple it if it doesn't belong in the root table itself.
*/
I think that in the second sentence "it" just before "if" is a typo.
Attached is a small patch for fixing that.
Best regards,
Etsuro Fujita
On 7/6/17 03:23, Etsuro Fujita wrote:
Here is a comment in ExecFindPartition() in execMain.c:
/*
* First check the root table's partition constraint, if any. No
point in
* routing the tuple it if it doesn't belong in the root table itself.
*/I think that in the second sentence "it" just before "if" is a typo.
Attached is a small patch for fixing that.
fixed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On 2017/08/01 6:09, Peter Eisentraut wrote:
On 7/6/17 03:23, Etsuro Fujita wrote:
Here is a comment in ExecFindPartition() in execMain.c:
/*
* First check the root table's partition constraint, if any. No
point in
* routing the tuple it if it doesn't belong in the root table itself.
*/I think that in the second sentence "it" just before "if" is a typo.
Attached is a small patch for fixing that.fixed
Thanks!
Best regards,
Etsuro Fujita
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers