replication_slot_catalog_xmin not explicitly initialized when creating procArray

Started by Wong, Yi Wenabout 9 years ago3 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t37067
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 28, 2026 at 05:56 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t37067_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t37067_1 && git checkout t37067_1

Patchset v1 (message #1) is on t37067_1

Jump to latest
#1Wong, Yi Wen
yiwong@amazon.com

Hi,

replication_slot_catalog_xmin is not explictly initialized to InvalidTransactionId.

Normally, there isn't an issue with this because a freshly mmap'd memory is zeroed, and the value of InvalidTransactionId is 0.

If the memory was not 0 for whatever reason, VACUUM would not behave as expected.

See attached patch.

Thanks,

Yi Wen

Attachments:

t37067_1
init_catalog_xmin.patchapplication/octet-stream; name=init_catalog_xmin.patchDownload+1-0
#2Masahiko Sawada
sawada.mshk@gmail.com
In reply to: Wong, Yi Wen (#1)
Re: replication_slot_catalog_xmin not explicitly initialized when creating procArray

On Sat, Jul 8, 2017 at 2:19 AM, Wong, Yi Wen <yiwong@amazon.com> wrote:

Hi,

replication_slot_catalog_xmin is not explictly initialized to
InvalidTransactionId.

Normally, there isn't an issue with this because a freshly mmap'd memory is
zeroed, and the value of InvalidTransactionId is 0.

If the memory was not 0 for whatever reason, VACUUM would not behave as
expected.

See attached patch.

Thank you for the patch. This change makes sense to me.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Peter Eisentraut
peter_e@gmx.net
In reply to: Masahiko Sawada (#2)
Re: replication_slot_catalog_xmin not explicitly initialized when creating procArray

On 7/9/17 21:23, Masahiko Sawada wrote:

On Sat, Jul 8, 2017 at 2:19 AM, Wong, Yi Wen <yiwong@amazon.com> wrote:

replication_slot_catalog_xmin is not explictly initialized to
InvalidTransactionId.

Thank you for the patch. This change makes sense to me.

Committed and backpatched

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers