Minor style cleanup in tab-complete.c

Started by Thomas Munroalmost 9 years ago3 messageshackers
Jump to latest
#1Thomas Munro
thomas.munro@gmail.com

Hi,

From the triviality department: I noticed some branches in
tab-complete.c's gargantuan if statement, mostly brand new, that break
from the established brace style. Should we fix that like this?

--
Thomas Munro
http://www.enterprisedb.com

Attachments:

remove-extraneous-braces-from-tab-complete.patchapplication/octet-stream; name=remove-extraneous-braces-from-tab-complete.patchDownload+0-24
#2Michael Paquier
michael@paquier.xyz
In reply to: Thomas Munro (#1)
Re: Minor style cleanup in tab-complete.c

On Wed, Jul 12, 2017 at 11:19 AM, Thomas Munro
<thomas.munro@enterprisedb.com> wrote:

From the triviality department: I noticed some branches in
tab-complete.c's gargantuan if statement, mostly brand new, that break
from the established brace style. Should we fix that like this?

For consistency I think it does.
--
Michael

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Heikki Linnakangas
heikki.linnakangas@enterprisedb.com
In reply to: Michael Paquier (#2)
Re: Minor style cleanup in tab-complete.c

On 07/12/2017 07:39 AM, Michael Paquier wrote:

On Wed, Jul 12, 2017 at 11:19 AM, Thomas Munro
<thomas.munro@enterprisedb.com> wrote:

From the triviality department: I noticed some branches in
tab-complete.c's gargantuan if statement, mostly brand new, that break
from the established brace style. Should we fix that like this?

For consistency I think it does.

Agreed. Committed, thanks.

- Heikki

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers