Jul 2020

3 commits
Eliminate cache lookup errors in SQL functions for object addresses
15 Jul 2020Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #592 of 3 reviewers saw the final version

Matches the complete remaining patch in #59, with small landing edits in objectaddress.c and its regression tests: reuse the fetched attribute name, restore the routine label, tidy comments and braces, and use unaligned test output. Michael describes these final adjustments in #64.

  • Aleksander Alekseevsaw an earlier versiontrailerReported successful feature, documentation, and installcheck-world testing in #10, before the substantial consistency rework in #39.
  • Dmitry Dolgovsaw the final versiontrailerIdentified the wrong operator flag in #43 and obsolete heap_close calls in #50, with subsequent changes limited to those corrections, naming, tests, and cleanup.
  • Daniel Gustafssonsaw the final versiontrailerTested and reviewed the series in #53, checked the refresh in #56, and read the final attached remainder in #62.
Refactor routines for name lookups of procedures and operators
6 Jul 2020Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #552 of 3 reviewers saw the final version

Takes the procedure/operator formatting prerequisite from the three-patch series in #55. Changes relative to that member are comments and declaration parameter names in regproc.c and regproc.h, explicitly enumerated in #58.

  • Aleksander Alekseevsaw an earlier versiontrailerTested the original object-address series in #10, before its procedure/operator formatting work evolved into the separate extended APIs in #39.
  • Dmitry Dolgovsaw the final versiontrailerExamined the formatting helpers and questioned their nullable-return documentation in #43, after which this prerequisite changed only in names and comments.
  • Daniel Gustafssonsaw the final versiontrailerReviewed and tested the series in #53 and reiterated the format_operator_extended documentation correction after checking #55 in #56.
Add new flag to format_type_extended() to get NULL for undefined type
6 Jul 2020Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #552 of 3 reviewers saw the final version

Takes only the type-formatting prerequisite from #55; its changes to format_type.c and builtins.h match that member modulo whitespace. The procedure/operator and object-address members were separate work.

  • Aleksander Alekseevsaw an earlier versiontrailerTested the earlier series and its type-formatting changes in #10, before the dedicated NULL-return flag was introduced in #39.
  • Dmitry Dolgovsaw the final versiontrailerReviewed the invalid-type branch and requested accurate NULL-return documentation in #43, with only comment and flag-name changes following.
  • Daniel Gustafssonsaw the final versiontrailerReported passing tests and reviewed the full series in #53, then checked the refreshed prerequisites in #56.

Dec 2018

1 commit
Introduce new extended routines for FDW and foreign server lookups
13 Dec 2018Michael Paquiermaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #361 of 1 reviewer saw the final version

Exactly matches the FDW prerequisite in #36 modulo whitespace, covering foreign.c, foreign.h, and fdwhandler.sgml. The object-address member remained pending, as confirmed in #38.

  • Álvaro Herrerasaw the final versiontrailerRequested compatibility-preserving APIs in #23, reviewed the revised prerequisite in #32, requested flag-style changes in #35, and accepted the update in #37.

Sep 2018

1 commit
Refactor routines for subscription and publication lookups
18 Sep 2018Michael Paquiermaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #312 of 2 reviewers saw the final version

Matches the publication/subscription prerequisite from #31, with only line wrapping differing in objectaddress.c. Its missing_ok additions to the catalog lookup routines and headers were committed separately from the other two members, as reported in #34.

  • Aleksander Alekseevsaw the final versiontrailerTested the original series in #10, and this prerequisite subsequently received only equivalent error-path organization, comments, and formatting changes.
  • Álvaro Herrerasaw the final versiontrailerRequested the missing_ok error-path layout in #17 and reviewed the publication/subscription prerequisite again in #32.

Feb 2018

1 commit
get_relid_attribute_name is dead, long live get_attname
12 Feb 2018Alvaro Herreramaster11beta1REL_19_STABLE11beta1REL_18_STABLE11beta1REL_17_STABLE11beta1REL_16_STABLE11beta1REL_15_STABLE11beta1REL_14_STABLE11beta1REL_13_STABLE11beta1+2 more
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #161 of 1 reviewer saw the final version

Takes the get_attname consolidation prerequisite from #16. Álvaro adjusts comments and error-path layout in lsyscache.c and replaces sepgsql's explicit NULL check with get_attname(..., false), then reports applying this member in #17.

  • Álvaro Herrerasaw the final versiontrailerReviewed and committed the attribute-name prerequisite, describing its application in #17; the credited reviewer is also the committer.

Credits across 6 commits

Author
Michael Paquier6
Reviewer
Aleksander Alekseev4
Alvaro Herrera3
Daniel Gustafsson3
Dmitry Dolgov3
Committer
Michael Paquier5
Alvaro Herrera1