Missing comment for max_logical_replication_workers in postgresql.conf.sample
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t37166psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 28, 2026 at 05:48 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t37166_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t37166_1 && git checkout t37166_1Patchset v1 (message #1) is on t37166_1
Hi,
I found that postgresql.conf.sample is missing a comment
to note that changing max_logical_replication_workers requires
restart of the server.
Other such parameters has the comments, so I think the new
parameter also needs this. Attached is a simple patch to fix
this.
Regards,
--
Yugo Nagata <nagata@sraoss.co.jp>
On Thu, Jul 27, 2017 at 10:14 AM, Yugo Nagata <nagata@sraoss.co.jp> wrote:
Hi,
I found that postgresql.conf.sample is missing a comment
to note that changing max_logical_replication_workers requires
restart of the server.Other such parameters has the comments, so I think the new
parameter also needs this. Attached is a simple patch to fix
this.
Good point. Similarly, dynamic_shared_memory_type and event_source are
required restarting to change but are not mentioned in
postgresql.conf.sample. Should we add a comment as well?
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Thu, 27 Jul 2017 14:38:29 +0900
Masahiko Sawada <sawada.mshk@gmail.com> wrote:
On Thu, Jul 27, 2017 at 10:14 AM, Yugo Nagata <nagata@sraoss.co.jp> wrote:
Hi,
I found that postgresql.conf.sample is missing a comment
to note that changing max_logical_replication_workers requires
restart of the server.Other such parameters has the comments, so I think the new
parameter also needs this. Attached is a simple patch to fix
this.Good point. Similarly, dynamic_shared_memory_type and event_source are
required restarting to change but are not mentioned in
postgresql.conf.sample. Should we add a comment as well?
I think so. The updated patch is attached.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Yugo Nagata <nagata@sraoss.co.jp>
Attachments:
postgresql.conf.sample.patch.v2application/octet-stream; name=postgresql.conf.sample.patch.v2Download+3-0
Attached patch looks good except the excessive tab stops:
+ # (change requires restart)
I will commit/push this with removing the excessive tab stops if
there's no objection.
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
On Thu, 27 Jul 2017 14:38:29 +0900
Masahiko Sawada <sawada.mshk@gmail.com> wrote:On Thu, Jul 27, 2017 at 10:14 AM, Yugo Nagata <nagata@sraoss.co.jp> wrote:
Hi,
I found that postgresql.conf.sample is missing a comment
to note that changing max_logical_replication_workers requires
restart of the server.Other such parameters has the comments, so I think the new
parameter also needs this. Attached is a simple patch to fix
this.Good point. Similarly, dynamic_shared_memory_type and event_source are
required restarting to change but are not mentioned in
postgresql.conf.sample. Should we add a comment as well?I think so. The updated patch is attached.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center--
Yugo Nagata <nagata@sraoss.co.jp>
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attached patch looks good except the excessive tab stops:
+ # (change requires restart)I will commit/push this with removing the excessive tab stops if
there's no objection.
Done. Each fix were pushed in separate commit because the version
needed to back patch are differ.
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers