Missing comment for max_logical_replication_workers in postgresql.conf.sample
Hi,
I found that postgresql.conf.sample is missing a comment
to note that changing max_logical_replication_workers requires
restart of the server.
Other such parameters has the comments, so I think the new
parameter also needs this. Attached is a simple patch to fix
this.
Regards,
--
Yugo Nagata <nagata@sraoss.co.jp>
Attachments:
postgresql.conf.sample.patchtext/x-diff; name=postgresql.conf.sample.patchDownload
diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample
index 2b1ebb7..d624ad3 100644
--- a/src/backend/utils/misc/postgresql.conf.sample
+++ b/src/backend/utils/misc/postgresql.conf.sample
@@ -277,6 +277,7 @@
# These settings are ignored on a publisher.
#max_logical_replication_workers = 4 # taken from max_worker_processes
+ # (change requires restart)
#max_sync_workers_per_subscription = 2 # taken from max_logical_replication_workers
On Thu, Jul 27, 2017 at 10:14 AM, Yugo Nagata <nagata@sraoss.co.jp> wrote:
Hi,
I found that postgresql.conf.sample is missing a comment
to note that changing max_logical_replication_workers requires
restart of the server.Other such parameters has the comments, so I think the new
parameter also needs this. Attached is a simple patch to fix
this.
Good point. Similarly, dynamic_shared_memory_type and event_source are
required restarting to change but are not mentioned in
postgresql.conf.sample. Should we add a comment as well?
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Thu, 27 Jul 2017 14:38:29 +0900
Masahiko Sawada <sawada.mshk@gmail.com> wrote:
On Thu, Jul 27, 2017 at 10:14 AM, Yugo Nagata <nagata@sraoss.co.jp> wrote:
Hi,
I found that postgresql.conf.sample is missing a comment
to note that changing max_logical_replication_workers requires
restart of the server.Other such parameters has the comments, so I think the new
parameter also needs this. Attached is a simple patch to fix
this.Good point. Similarly, dynamic_shared_memory_type and event_source are
required restarting to change but are not mentioned in
postgresql.conf.sample. Should we add a comment as well?
I think so. The updated patch is attached.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Yugo Nagata <nagata@sraoss.co.jp>
Attachments:
postgresql.conf.sample.patch.v2application/octet-stream; name=postgresql.conf.sample.patch.v2Download
diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample
index 2b1ebb7..45420dc 100644
--- a/src/backend/utils/misc/postgresql.conf.sample
+++ b/src/backend/utils/misc/postgresql.conf.sample
@@ -130,6 +130,7 @@
# windows
# mmap
# use none to disable dynamic shared memory
+ # (change requires restart)
# - Disk -
@@ -277,6 +278,7 @@
# These settings are ignored on a publisher.
#max_logical_replication_workers = 4 # taken from max_worker_processes
+ # (change requires restart)
#max_sync_workers_per_subscription = 2 # taken from max_logical_replication_workers
@@ -377,6 +379,7 @@
#syslog_split_messages = on
# This is only relevant when logging to eventlog (win32):
+# (change requires restart)
#event_source = 'PostgreSQL'
# - When to Log -
Attached patch looks good except the excessive tab stops:
+ # (change requires restart)
I will commit/push this with removing the excessive tab stops if
there's no objection.
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
On Thu, 27 Jul 2017 14:38:29 +0900
Masahiko Sawada <sawada.mshk@gmail.com> wrote:On Thu, Jul 27, 2017 at 10:14 AM, Yugo Nagata <nagata@sraoss.co.jp> wrote:
Hi,
I found that postgresql.conf.sample is missing a comment
to note that changing max_logical_replication_workers requires
restart of the server.Other such parameters has the comments, so I think the new
parameter also needs this. Attached is a simple patch to fix
this.Good point. Similarly, dynamic_shared_memory_type and event_source are
required restarting to change but are not mentioned in
postgresql.conf.sample. Should we add a comment as well?I think so. The updated patch is attached.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center--
Yugo Nagata <nagata@sraoss.co.jp>
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attached patch looks good except the excessive tab stops:
+ # (change requires restart)I will commit/push this with removing the excessive tab stops if
there's no objection.
Done. Each fix were pushed in separate commit because the version
needed to back patch are differ.
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers