Notice message of ALTER SUBSCRIPTION ... RERESH PUBLICATIION

Started by Yugo Nagataabout 9 years ago3 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t37169
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 28, 2026 at 05:43 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t37169_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t37169_1 && git checkout t37169_1

Patchset v1 (message #1) is on t37169_1

Jump to latest
#1Yugo Nagata
nagata@sraoss.co.jp

Hi,

When we run ALTER SUBSCRIPTION ... REFRESH PUBLICATION and there is
an unkown table at local, it says;

NOTICE: added subscription for table public.tbl

I feel this a bit misleading because it says a subscription is added
but actually new subscription object is not created. Of cause, I can
understand the intention this message says, but I feel that
it is better to use other expression. For example, how about saying

NOTICE: table public.tbl is added to subscription sub1

as proposed in the attached patch. This also fixes the message
when a table is removed from a subscription.

Regards,

--
Yugo Nagata <nagata@sraoss.co.jp>

Attachments:

t37169_1
alter_subscription_refresh.patchtext/x-diff; name=alter_subscription_refresh.patchDownload+6-4
#2Peter Eisentraut
peter_e@gmx.net
In reply to: Yugo Nagata (#1)
Re: Notice message of ALTER SUBSCRIPTION ... RERESH PUBLICATIION

On 7/27/17 20:51, Yugo Nagata wrote:

When we run ALTER SUBSCRIPTION ... REFRESH PUBLICATION and there is
an unkown table at local, it says;

NOTICE: added subscription for table public.tbl

I feel this a bit misleading because it says a subscription is added
but actually new subscription object is not created. Of cause, I can
understand the intention this message says, but I feel that
it is better to use other expression. For example, how about saying

NOTICE: table public.tbl is added to subscription sub1

as proposed in the attached patch. This also fixes the message
when a table is removed from a subscription.

Fixed, thanks. (Note that per another discussion, these are now DEBUG
messages.)

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Yugo Nagata
nagata@sraoss.co.jp
In reply to: Peter Eisentraut (#2)
Re: Notice message of ALTER SUBSCRIPTION ... RERESH PUBLICATIION

On Mon, 7 Aug 2017 09:46:56 -0400
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:

On 7/27/17 20:51, Yugo Nagata wrote:

When we run ALTER SUBSCRIPTION ... REFRESH PUBLICATION and there is
an unkown table at local, it says;

NOTICE: added subscription for table public.tbl

I feel this a bit misleading because it says a subscription is added
but actually new subscription object is not created. Of cause, I can
understand the intention this message says, but I feel that
it is better to use other expression. For example, how about saying

NOTICE: table public.tbl is added to subscription sub1

as proposed in the attached patch. This also fixes the message
when a table is removed from a subscription.

Fixed, thanks. (Note that per another discussion, these are now DEBUG
messages.)

Thanks, too.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Yugo Nagata <nagata@sraoss.co.jp>

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers