Gettting warning message during PostgreSQL-9.5 installation on Windows

Started by Ashutosh Sharmaover 8 years ago2 messages
#1Ashutosh Sharma
ashu.coek88@gmail.com
1 attachment(s)

Hi,

I am getting this warning message when trying to install
PostgreSQL-v9.5 on Windows with Perl-5.22 and above,

Unescaped left brace in regex is deprecated, passed through in regex;
marked by <-- HERE in m/Project\("{ <-- HERE 8BC9CEB8-8B4A-11D0-8D11
00A0C91BC942}"\) = "([^"]+)"/ at Install.pm line 220. Installing
version 9.5 for debug in
C:\Users\ashu\git-clone-postgresql\postgresql\TMP\test

Attached is the patch that fixes this issue.

Please note that from perl-5.26 onwards, this is considered as a
syntax error instead of warning.

Also, I could see that, there is already a git commit in
PostgreSQL-9.6 branch that fixes this but was not back patch to 9.5
and may be below branches.

commit 76a1c97bf21c301f61bb41345e0cdd0d365b2086
Author: Andrew Dunstan <andrew@dunslane.net>
Date: Fri Apr 8 12:50:30 2016 -0400

Silence warning from modern perl about unescaped braces

--
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com

Attachments:

Silence_warning_unescaped_braces.patchapplication/octet-stream; name=Silence_warning_unescaped_braces.patchDownload
diff --git a/src/tools/msvc/Install.pm b/src/tools/msvc/Install.pm
index 2d037dd..4e75ead 100644
--- a/src/tools/msvc/Install.pm
+++ b/src/tools/msvc/Install.pm
@@ -217,7 +217,7 @@ sub CopySolutionOutput
 	my $conf   = shift;
 	my $target = shift;
 	my $rem =
-	  qr{Project\("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}"\) = "([^"]+)"};
+	  qr{Project\("\{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942\}"\) = "([^"]+)"};
 
 	my $sln = read_file("pgsql.sln") || croak "Could not open pgsql.sln\n";
 
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Ashutosh Sharma (#1)
Re: Gettting warning message during PostgreSQL-9.5 installation on Windows

Ashutosh Sharma <ashu.coek88@gmail.com> writes:

I am getting this warning message when trying to install
PostgreSQL-v9.5 on Windows with Perl-5.22 and above,
Unescaped left brace in regex is deprecated, passed through in regex;
Please note that from perl-5.26 onwards, this is considered as a
syntax error instead of warning.

Mmm, yeah, we'd better fix it then, because people will surely try
to use older branches with current Perl. Pushed.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers