Logical replication message type 'Y' is missing in docs

Started by Masahiko Sawadaover 8 years ago3 messages

sawada.mshk@gmail.com

over 8 years ago

1 attachment(s)

Hi,

There is a type of logical replication message 'Y' for data types, but
it's not documented in section 52.9. Logical Replication Message
Formats. Attached patch fixes this. I think it can be PG10 item.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachments:

message_type_in_protocol_sgml.patchapplication/octet-stream; name=message_type_in_protocol_sgml.patchDownload

diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 6731fa9..4aba99a 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6198,6 +6198,50 @@ Relation
 
 <varlistentry>
 <term>
+Type
+</term>
+<listitem>
+<para>
+
+<variablelist>
+<varlistentry>
+<term>
+        Byte1('Y')
+</term>
+<listitem>
+<para>
+                Identifies the message as an type message.
+</para>
+</listitem>
+</varlistentry>
+<varlistentry>
+<term>
+        Int32
+</term>
+<listitem>
+<para>
+                OID of the data type.
+</para>
+</listitem>
+</varlistentry>
+<varlistentry>
+<term>
+        String
+</term>
+<listitem>
+<para>
+                Name of the data type.
+</para>
+</listitem>
+</varlistentry>
+
+</variablelist>
+</para>
+</listitem>
+</varlistentry>
+
+<varlistentry>
+<term>
 Insert
 </term>
 <listitem>

Peter Eisentraut

peter.eisentraut@2ndquadrant.com

over 8 years ago

In reply to: Masahiko Sawada (#1)

Re: Logical replication message type 'Y' is missing in docs

On 8/9/17 20:22, Masahiko Sawada wrote:

There is a type of logical replication message 'Y' for data types, but
it's not documented in section 52.9. Logical Replication Message
Formats. Attached patch fixes this. I think it can be PG10 item.

Committed with some tweaking.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Masahiko Sawada

sawada.mshk@gmail.com

over 8 years ago

In reply to: Peter Eisentraut (#2)

Re: Logical replication message type 'Y' is missing in docs

On Wed, Aug 16, 2017 at 4:38 AM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:

On 8/9/17 20:22, Masahiko Sawada wrote:

There is a type of logical replication message 'Y' for data types, but
it's not documented in section 52.9. Logical Replication Message
Formats. Attached patch fixes this. I think it can be PG10 item.

Committed with some tweaking.

Thank you!

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers