Apr 2021

1 commit
docs: Update TOAST storage docs for configurable compression.
13 Apr 2021Robert Haasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #4561 of 1 reviewer saw the final version

The two storage.sgml hunks match #456, with the accidentally omitted word “data” restored following #457.

  • Justin Pryzbysaw the final versionLLM analysis, 100% sureIdentified the missing word in the storage documentation at #457, which the committed patch restores.

Mar 2021

14 commits
Further tweaking of pg_dump's handling of default_toast_compression.
30 Mar 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surewritten from the discussion, no matching patch

Tom proposed emitting pglz defaults for pre-v14 sources at #436 and announced the decision at #454; no attachment contains the resulting dumpToastCompression change.

Fix interaction of TOAST compression with expression indexes.
25 Mar 2021Robert Haasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #4481 of 2 reviewers saw the final version

Commits the expression-index bugfix from #448, preserving its runtime-default checks in indextuple.c and brin_tuple.c while editing comments; the separate psql display patch is omitted. The landing is confirmed at #450.

  • Justin Pryzbysaw an earlier versionLLM analysis, 97% sureRequested a regression reproducer at #430, incorporated before the later runtime-default redesign.
  • Robert Haassaw the final versioncommittercommitted the patch
Tidy up more loose ends related to configurable TOAST compression.
24 Mar 2021Robert Haasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surelanded as postedfrom patchset #4242 of 2 reviewers saw the final version

The complete six-file diff has the same stable git patch ID as #424; the attachment and commit credit Justin’s original patch and Robert’s extensive rewriting.

  • Tom Lanesaw the final versionLLM analysis, 97% sureReviewed macro visibility and GUC error handling at #421, corrected his interpretation at #426, and is explicitly credited by the commit.
  • Robert Haassaw the final versioncommittercommitted the patch
Short-circuit slice requests that are for more than the object's size.
22 Mar 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #4132 of 2 reviewers saw the final version

Uses the shared detoast.c guard and accessor from #413, with expanded comments, an unsigned cast, and RAWSIZE-to-EXTSIZE naming adjusted to the immediately preceding macro cleanup.

  • Robert Haassaw the final versionLLM analysis, 93% sureExamined the size-field invariant at #414 and explained why the shared decompression guard is valid.
  • Tom Lanesaw the final versioncommittercommitted the patch
Mostly-cosmetic adjustments of TOAST-related macros.
22 Mar 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surewritten from the discussion, no matching patch

The macro-renaming and header cleanup follow #409 and #415, including unsigned shifts and correction of the accessor’s ignored argument; no attached patch matches this cleanup.

Remove useless configure probe for <lz4/lz4.h>.
22 Mar 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surewritten from the discussion, no matching patch

Implements Tom’s observation at #401 that probing lz4/lz4.h is pointless because the C code cannot use that spelling, removing the probe and generated definitions.

Error on invalid TOAST compression in CREATE or ALTER TABLE.
22 Mar 2021Robert Haasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #4051 of 1 reviewer saw the final version

Exactly matches the invalid-compression-name component of #405, including CREATE/ALTER regression cases; the remaining series components landed separately.

  • Robert Haassaw the final versioncommittercommitted the patch
docs: Fix omissions related to configurable TOAST compression.
22 Mar 2021Robert Haasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #4051 of 1 reviewer saw the final version

Takes the two documentation components of #405, rewriting config.sgml and pg_dump.sgml to distinguish defaults for new columns from new values and to cover inline TOAST, as explained at #408.

  • Robert Haassaw the final versioncommittercommitted the patch
More code cleanup for configurable TOAST compression.
22 Mar 2021Robert Haasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #4051 of 1 reviewer saw the final version

Combines the char-versus-OID correction in tablecmds.c and duplicate-macro removal from #405, with only a blank-line adjustment; #408 identifies those two components.

  • Robert Haassaw the final versioncommittercommitted the patch
Bring configure support for LZ4 up to snuff.
21 Mar 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 96% surewritten from the discussion, no matching patch

Tom’s implementation filters pkg-config flags into CPPFLAGS/LDFLAGS and adds AC_CHECK_LIB, following #392; #400 explicitly says it supersedes Justin’s attached fix. It also differs from Robert’s pkg-config-removal proposal #354.

Make compression.sql regression test independent of default.
21 Mar 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #3951 of 1 reviewer saw the final version

Matches the explicit pglz settings in compression.sql and both expected-output files from #395, adding only an explanatory comment.

  • Tom Lanesaw the final versioncommittercommitted the patch
Use valid compression method in brin_form_tuple
20 Mar 2021Tomas Vondramaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #3751 of 1 reviewer saw the final version

Uses the BRIN type-match fix from #375, moving GetDefaultToastCompression into an explicit else branch and correcting the comment after #376.

  • Justin Pryzbysaw the final versiontrailerRequested the explicit fallback branch and comment correction at #376, incorporated as confirmed by #391.
Fix up pg_dump's handling of per-attribute compression options.
20 Mar 2021Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #3681 of 1 reviewer saw the final version

Takes Justin’s pg_dump cleanup and archive-state/ALTER components from #368, adding a server-version guard and cosmetic edits as confirmed at #380. The competing #369 was rejected for failing non-text dumps at #377.

  • Tom Lanesaw the final versioncommittercommitted the patch
Allow configurable LZ4 TOAST compression.
19 Mar 2021Robert Haasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #3402 of 10 reviewers saw the final version

Commits the core compression component of #340, already combining the GUC and ALTER work; preparatory raw-Datum patches, the CI-only switch, and recursive-ALTER experiment are excluded. Changes are principally comments, added function documentation, configure placement, and a catalog-version bump, consistent with the landing report #345.

  • Tomas Vondrasaw an earlier versionLLM analysis, 97% sureReviewed cache correctness, cross-table compression, indexes, and LZ4 errors and ran benchmarks at #16, #37, #158, and #178.
  • Alvaro Herrerasaw an earlier versionLLM analysis, 94% sureProposed the adopted access-method integration at #41 and refined its catalog representation at #196, before the builtin-only redesign.
  • Andres Freundsaw an earlier versionLLM analysis, 97% sureReviewed header encoding and later challenged dispatch indirection, tuple equality, and recompression costs at #141 and #319, before substantial revisions.
  • Oleg Bartunovsaw the final versionLLM analysis, 88% sureThe commit explicitly credits Oleg with design input and review; the thread’s #61 supplies compression results but does not establish review of a particular attached version.
  • Alexander Korotkovsaw an earlier versionLLM analysis, 95% sureIdentified obsolete server-version checks at #115, subsequently corrected before the major redesign.
  • Ildar Musinsaw an earlier versionLLM analysis, 97% sureReviewed storage semantics, macros, CREATE TABLE LIKE, and options, and reported successful tests at #95, #97, and #127.
  • Amit Khandekarsaw an earlier versionLLM analysis, 97% sureReviewed the rebased series and reported zlib benchmarks and implementation issues at #151.
  • Mark Dilgersaw an earlier versionLLM analysis, 97% sureIdentified pglz format and round-trip compatibility problems at #152, prompting the revised header encoding.
  • Neha Sharmasaw an earlier versionLLM analysis, 97% sureReported testing and detailed before-and-after coverage for forty affected files at #220.
  • Robert Haassaw the final versioncommittercommitted the patch

Credits across 15 commits

Author
Justin PryzbyLLM5
Dilip KumarLLM4
Robert HaasLLM1
Tomas Vondra1
Reviewer
Robert Haascommitter6
Tom Lanecommitter3
Justin Pryzby1
Committer
Robert Haas7
Tom Lane7
Tomas Vondra1

N LLM means N of the credits come from LLM analysis, not from commit trailers.