pgsql: Add much-more-extensive TAP tests for pgbench.
Add much-more-extensive TAP tests for pgbench.
Fabien Coelho, reviewed by Nikolay Shaplov and myself
Discussion: /messages/by-id/alpine.DEB.2.20.1704171422500.4025@lancre
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/ed8a7c6fcf92b6b57ed8003bbd4a4eb92a6039bc
Modified Files
--------------
src/bin/pgbench/t/001_pgbench.pl | 25 --
src/bin/pgbench/t/001_pgbench_with_server.pl | 498 +++++++++++++++++++++++++++
src/bin/pgbench/t/002_pgbench_no_server.pl | 123 +++++++
src/test/perl/PostgresNode.pm | 31 +-
src/test/perl/TestLib.pm | 38 ++
5 files changed, 683 insertions(+), 32 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
On 9/8/17 09:32, Tom Lane wrote:
Add much-more-extensive TAP tests for pgbench.
Fabien Coelho, reviewed by Nikolay Shaplov and myself
The use of done_testing() raises the requirement of Test::More from 0.82
to 0.87. That seems OK, but we should update the version requirement in
TestLib.pm. Any concerns?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
On 9/8/17 09:32, Tom Lane wrote:
Add much-more-extensive TAP tests for pgbench.
The use of done_testing() raises the requirement of Test::More from 0.82
to 0.87. That seems OK, but we should update the version requirement in
TestLib.pm. Any concerns?
Probably not, given that none of the buildfarm machines have whined
(although I'm not sure if all the older ones run the TAP tests?).
I have some recollection that when I was trying to set up
the-oldest-supported-Perl-version on prairiedog, I couldn't even
find Test::More 0.82 anywhere. What's actually there is a good
bit newer, anyway.
regards, tom lane
On 3/2/18 20:19, Tom Lane wrote:
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
On 9/8/17 09:32, Tom Lane wrote:
Add much-more-extensive TAP tests for pgbench.
The use of done_testing() raises the requirement of Test::More from 0.82
to 0.87. That seems OK, but we should update the version requirement in
TestLib.pm. Any concerns?Probably not, given that none of the buildfarm machines have whined
(although I'm not sure if all the older ones run the TAP tests?).
done
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services