pgsql: passwordcheck: Add test suite
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t37411psql -h localhost -U postgresBuilt from patchset v3 (message #3), July 27, 2026 at 10:17 PM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t37411_3 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t37411_3 && git checkout t37411_3Patchset v3 (message #3) is on t37411_3
passwordcheck: Add test suite
Also improve one error message.
Reviewed-by: David Steele <david@pgmasters.net>
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/af7211e92dc2bba66f90de9e5bea6ae5fa914c61
Modified Files
--------------
contrib/passwordcheck/.gitignore | 4 ++++
contrib/passwordcheck/Makefile | 5 +++++
contrib/passwordcheck/expected/passwordcheck.out | 18 ++++++++++++++++++
contrib/passwordcheck/passwordcheck.c | 2 +-
contrib/passwordcheck/passwordcheck.conf | 1 +
contrib/passwordcheck/sql/passwordcheck.sql | 21 +++++++++++++++++++++
6 files changed, 50 insertions(+), 1 deletion(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
On Fri, Sep 15, 2017 at 11:46 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
passwordcheck: Add test suite
Also improve one error message.
Reviewed-by: David Steele <david@pgmasters.net>
Sorry for showing up late for this topic.
+REGRESS_OPTS = --temp-config $(srcdir)/passwordcheck.conf
+REGRESS = passwordcheck
+# disabled because these tests require setting shared_preload_libraries
+NO_INSTALLCHECK = 1
You could have avoided all that by just issuing "load
'passwordcheck';" at the beginning of the test. And you gain support
for installcheck this way.
--
Michael--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Sep 15, 2017 at 12:02 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
On Fri, Sep 15, 2017 at 11:46 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
passwordcheck: Add test suite
Also improve one error message.
Reviewed-by: David Steele <david@pgmasters.net>
Sorry for showing up late for this topic. +REGRESS_OPTS = --temp-config $(srcdir)/passwordcheck.conf +REGRESS = passwordcheck +# disabled because these tests require setting shared_preload_libraries +NO_INSTALLCHECK = 1 You could have avoided all that by just issuing "load 'passwordcheck';" at the beginning of the test. And you gain support for installcheck this way.
In short you just need the attached ;)
--
Michael
On 9/15/17 00:20, Michael Paquier wrote:
On Fri, Sep 15, 2017 at 12:02 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:On Fri, Sep 15, 2017 at 11:46 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
passwordcheck: Add test suite
Also improve one error message.
Reviewed-by: David Steele <david@pgmasters.net>
Sorry for showing up late for this topic. +REGRESS_OPTS = --temp-config $(srcdir)/passwordcheck.conf +REGRESS = passwordcheck +# disabled because these tests require setting shared_preload_libraries +NO_INSTALLCHECK = 1 You could have avoided all that by just issuing "load 'passwordcheck';" at the beginning of the test. And you gain support for installcheck this way.In short you just need the attached ;)
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers