pgsql: passwordcheck: Add test suite
passwordcheck: Add test suite
Also improve one error message.
Reviewed-by: David Steele <david@pgmasters.net>
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/af7211e92dc2bba66f90de9e5bea6ae5fa914c61
Modified Files
--------------
contrib/passwordcheck/.gitignore | 4 ++++
contrib/passwordcheck/Makefile | 5 +++++
contrib/passwordcheck/expected/passwordcheck.out | 18 ++++++++++++++++++
contrib/passwordcheck/passwordcheck.c | 2 +-
contrib/passwordcheck/passwordcheck.conf | 1 +
contrib/passwordcheck/sql/passwordcheck.sql | 21 +++++++++++++++++++++
6 files changed, 50 insertions(+), 1 deletion(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
On Fri, Sep 15, 2017 at 11:46 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
passwordcheck: Add test suite
Also improve one error message.
Reviewed-by: David Steele <david@pgmasters.net>
Sorry for showing up late for this topic.
+REGRESS_OPTS = --temp-config $(srcdir)/passwordcheck.conf
+REGRESS = passwordcheck
+# disabled because these tests require setting shared_preload_libraries
+NO_INSTALLCHECK = 1
You could have avoided all that by just issuing "load
'passwordcheck';" at the beginning of the test. And you gain support
for installcheck this way.
--
Michael--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Sep 15, 2017 at 12:02 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
On Fri, Sep 15, 2017 at 11:46 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
passwordcheck: Add test suite
Also improve one error message.
Reviewed-by: David Steele <david@pgmasters.net>
Sorry for showing up late for this topic. +REGRESS_OPTS = --temp-config $(srcdir)/passwordcheck.conf +REGRESS = passwordcheck +# disabled because these tests require setting shared_preload_libraries +NO_INSTALLCHECK = 1 You could have avoided all that by just issuing "load 'passwordcheck';" at the beginning of the test. And you gain support for installcheck this way.
In short you just need the attached ;)
--
Michael
Attachments:
0001-Simplify-new-test-suite-handling-of-passwordcheck.patchapplication/octet-stream; name=0001-Simplify-new-test-suite-handling-of-passwordcheck.patchDownload+5-5
On 9/15/17 00:20, Michael Paquier wrote:
On Fri, Sep 15, 2017 at 12:02 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:On Fri, Sep 15, 2017 at 11:46 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
passwordcheck: Add test suite
Also improve one error message.
Reviewed-by: David Steele <david@pgmasters.net>
Sorry for showing up late for this topic. +REGRESS_OPTS = --temp-config $(srcdir)/passwordcheck.conf +REGRESS = passwordcheck +# disabled because these tests require setting shared_preload_libraries +NO_INSTALLCHECK = 1 You could have avoided all that by just issuing "load 'passwordcheck';" at the beginning of the test. And you gain support for installcheck this way.In short you just need the attached ;)
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers