[PATCH] Minor patch to correct symbol name in logs

Started by Vaishnavi Prabakaranover 8 years ago2 messages
#1Vaishnavi Prabakaran
vaishnaviprabakaran@gmail.com
1 attachment(s)

Hi,

Backend's lo_functions were renamed to avoid conflicting with libpq
prototypes in commit - 6fc547960dbe0b8bd6cefae5ab7ec3605a5c46fc.

Logs inside those functions still refer to old symbol names, Here is the
small patch to update the same.

Thanks & Regards,
Vaishnavi,
Fujitsu Australia.

Attachments:

0001-Debug-log-correction-to-reflect-changed-function-nam.patchapplication/octet-stream; name=0001-Debug-log-correction-to-reflect-changed-function-nam.patchDownload
From eb794377c0ca33577083bd6fae6deed41b8f6f17 Mon Sep 17 00:00:00 2001
From: Vaishnavi Prabakaran <vaishnavip@fast.au.fujitsu.com>
Date: Wed, 20 Sep 2017 15:09:28 +1000
Subject: [PATCH] Debug log correction to reflect changed function name

---
 src/backend/libpq/be-fsstubs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/backend/libpq/be-fsstubs.c b/src/backend/libpq/be-fsstubs.c
index bf45461..5721c74 100644
--- a/src/backend/libpq/be-fsstubs.c
+++ b/src/backend/libpq/be-fsstubs.c
@@ -101,7 +101,7 @@ be_lo_open(PG_FUNCTION_ARGS)
 	int			fd;
 
 #if FSDB
-	elog(DEBUG4, "lo_open(%u,%d)", lobjId, mode);
+	elog(DEBUG4, "be_lo_open(%u,%d)", lobjId, mode);
 #endif
 
 	CreateFSContext();
@@ -132,7 +132,7 @@ be_lo_close(PG_FUNCTION_ARGS)
 				 errmsg("invalid large-object descriptor: %d", fd)));
 
 #if FSDB
-	elog(DEBUG4, "lo_close(%d)", fd);
+	elog(DEBUG4, "be_lo_close(%d)", fd);
 #endif
 
 	inv_close(cookies[fd]);
-- 
2.7.4.windows.1

#2Peter Eisentraut
peter.eisentraut@2ndquadrant.com
In reply to: Vaishnavi Prabakaran (#1)
Re: [PATCH] Minor patch to correct symbol name in logs

On 9/20/17 01:56, Vaishnavi Prabakaran wrote:

Backend's lo_functions were renamed to avoid conflicting with libpq
prototypes in commit - 6fc547960dbe0b8bd6cefae5ab7ec3605a5c46fc. 

Logs inside those functions still refer to old symbol names, Here is the
small patch to update the same.

I think those debug messages refer to the SQL name of the function, so
they look correct to me as is.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers