Minor comment issue in receivelog.c
Started by Bernd Helmleabout 8 years ago2 messages
Please find a minor comment fix for receivelog.c, HandleCopyStream().
The comments talks about a START_STREAMING command, but i think
START_REPLICATION is what's meant here.
Bernd
Attachments:
receivelog_comment.patchtext/x-patch; charset=UTF-8; name=receivelog_comment.patchDownload
diff --git a/src/bin/pg_basebackup/receivelog.c b/src/bin/pg_basebackup/receivelog.c
index 888458f4a9..befbbb092b 100644
--- a/src/bin/pg_basebackup/receivelog.c
+++ b/src/bin/pg_basebackup/receivelog.c
@@ -763,7 +763,7 @@ ReadEndOfStreamingResult(PGresult *res, XLogRecPtr *startpos, uint32 *timeline)
/*
* The main loop of ReceiveXlogStream. Handles the COPY stream after
- * initiating streaming with the START_STREAMING command.
+ * initiating streaming with the START_REPLICATION command.
*
* If the COPY ends (not necessarily successfully) due a message from the
* server, returns a PGresult and sets *stoppos to the last byte written.
Re: Minor comment issue in receivelog.c
On Thu, Nov 2, 2017 at 5:18 PM, Bernd Helmle <mailings@oopsware.de> wrote:
Please find a minor comment fix for receivelog.c, HandleCopyStream().
The comments talks about a START_STREAMING command, but i think
START_REPLICATION is what's meant here.
Yeah, it is. Confusingly enough, START_STREAMING is what's returned by
START_REPLICATION.
Applied, thanks.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>