Commitfests
2018-01Committed
Remove duplicate setting in test/recovery/Makefile
Committer
  • Robert Haas (rhaas)
Participants
Masahiko Sawada
Masahiko Sawada
Michael Paquier
Michael Paquier
Robert Haas
Robert Haas
Attachments
Thread Outline
#1Masahiko SawadaMasahiko Sawada
Nov 08, 2017
#2Michael Paquier↳Michael Paquierto Masahiko Sawada (#1)
Nov 08, 2017
#3Masahiko Sawada↳Masahiko Sawadato Michael Paquier (#2)
Nov 16, 2017
#4Robert Haas↳Robert Haasto Masahiko Sawada (#3)
Nov 16, 2017
#5Masahiko Sawada↳Masahiko Sawadato Robert Haas (#4)
Nov 17, 2017

Remove duplicate setting in test/recovery/Makefile

Started by Masahiko Sawadaabout 8 years ago5 messages
#1Masahiko Sawada
Masahiko Sawada
sawada.mshk@gmail.com
1 attachment(s)

Hi,

I found that EXTRA_INSTALL is doubly set at both top and bottom of the
src/test/recovery/Makefile. Is it necessary?

Attached patch fixes this.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachments:

remove_duplicate_setting.patchapplication/octet-stream; name=remove_duplicate_setting.patchDownload
diff --git a/src/test/recovery/Makefile b/src/test/recovery/Makefile
index 142a1b8..e31accf 100644
--- a/src/test/recovery/Makefile
+++ b/src/test/recovery/Makefile
@@ -20,5 +20,3 @@ check:
 
 clean distclean maintainer-clean:
 	rm -rf tmp_check
-
-EXTRA_INSTALL = contrib/test_decoding
#2Michael Paquier
Michael Paquier
michael.paquier@gmail.com
In reply to: Masahiko Sawada (#1)
Re: Remove duplicate setting in test/recovery/Makefile

On Wed, Nov 8, 2017 at 10:38 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:

Hi,

I found that EXTRA_INSTALL is doubly set at both top and bottom of the
src/test/recovery/Makefile. Is it necessary?

Attached patch fixes this.

Indeed, there is some bad overlap between d851bef and 1148e22a. Better
to CC Simon who committed both things.
--
Michael

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Masahiko Sawada
Masahiko Sawada
sawada.mshk@gmail.com
In reply to: Michael Paquier (#2)
Re: [HACKERS] Remove duplicate setting in test/recovery/Makefile

On Wed, Nov 8, 2017 at 10:46 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:

On Wed, Nov 8, 2017 at 10:38 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:

Hi,

I found that EXTRA_INSTALL is doubly set at both top and bottom of the
src/test/recovery/Makefile. Is it necessary?

Attached patch fixes this.

Indeed, there is some bad overlap between d851bef and 1148e22a. Better
to CC Simon who committed both things.

Thank you. I've added this to the next CF so as not to forget.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

#4Robert Haas
Robert Haas
robertmhaas@gmail.com
In reply to: Masahiko Sawada (#3)
Re: [HACKERS] Remove duplicate setting in test/recovery/Makefile

On Thu, Nov 16, 2017 at 7:15 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:

Thank you. I've added this to the next CF so as not to forget.

Committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

#5Masahiko Sawada
Masahiko Sawada
sawada.mshk@gmail.com
In reply to: Robert Haas (#4)
Re: [HACKERS] Remove duplicate setting in test/recovery/Makefile

On Fri, Nov 17, 2017 at 5:36 AM, Robert Haas <robertmhaas@gmail.com> wrote:

On Thu, Nov 16, 2017 at 7:15 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:

Thank you. I've added this to the next CF so as not to forget.

Committed.

Thank you.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

← Back to Topics