(spelling) Ensure header of postgresql.auto.conf is consistent
Attached a patch that ensures the header of postgresql.auto.conf is
consistent, whether created by initdb or recreated when ALTER SYSTEM
is issued.
The tiny difference caused some false-positives on our configuration
management identifying changes, which was enough of an itch for me to
scratch.
regards,
Feike Steenbergen
Attachments:
0001-Make-header-of-postgresql.conf.auto-consistent.patchapplication/octet-stream; name=0001-Make-header-of-postgresql.conf.auto-consistent.patchDownload
From 5ab6eff285ce29a1605995052de23fa05dfe511f Mon Sep 17 00:00:00 2001
From: Feike Steenbergen <feike.steenbergen@adyen.com>
Date: Thu, 9 Nov 2017 09:01:28 +0100
Subject: [PATCH 1/1] Make header of postgresql.conf.auto consistent
---
src/backend/utils/misc/guc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index a609619f4d..da061023f5 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -6944,7 +6944,7 @@ write_auto_conf_file(int fd, const char *filename, ConfigVariable *head)
/* Emit file header containing warning comment */
appendStringInfoString(&buf, "# Do not edit this file manually!\n");
- appendStringInfoString(&buf, "# It will be overwritten by ALTER SYSTEM command.\n");
+ appendStringInfoString(&buf, "# It will be overwritten by the ALTER SYSTEM command.\n");
errno = 0;
if (write(fd, buf.data, buf.len) != buf.len)
--
2.13.6 (Apple Git-96)
Em qui, 9 de nov de 2017 às 06:15, Feike Steenbergen <
feikesteenbergen@gmail.com> escreveu:
Attached a patch that ensures the header of postgresql.auto.conf is
consistent, whether created by initdb or recreated when ALTER SYSTEM
is issued.The tiny difference caused some false-positives on our configuration
management identifying changes, which was enough of an itch for me to
scratch.
Interesting... IMHO this typo should be backpatched to 9.4 when ALTER
SYSTEM was introduced.
Regards,
--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
Show quoted text
Timbira: http://www.timbira.com.br
Blog: http://fabriziomello.github.io
Linkedin: http://br.linkedin.com/in/fabriziomello
Twitter: http://twitter.com/fabriziomello
Github: http://github.com/fabriziomello
On Thu, Nov 9, 2017 at 6:25 PM, Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:
Interesting... IMHO this typo should be backpatched to 9.4 when ALTER SYSTEM
was introduced.
Yeah, that's harmless.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
=?UTF-8?Q?Fabr=C3=ADzio_de_Royes_Mello?= <fabriziomello@gmail.com> writes:
Em qui, 9 de nov de 2017 às 06:15, Feike Steenbergen <
feikesteenbergen@gmail.com> escreveu:Attached a patch that ensures the header of postgresql.auto.conf is
consistent, whether created by initdb or recreated when ALTER SYSTEM
is issued.
Interesting... IMHO this typo should be backpatched to 9.4 when ALTER
SYSTEM was introduced.
Agreed, and done.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers