Typo in auth-scram.c

Started by Michael Paquierabout 8 years ago3 messages
#1Michael Paquier
michael.paquier@gmail.com
1 attachment(s)

Hi all,

auth-scram.c is visibly not able to do things in a deterministic way,
that's more determinisitc:

--- a/src/backend/libpq/auth-scram.c
+++ b/src/backend/libpq/auth-scram.c
@@ -1116,7 +1116,7 @@ build_server_final_message(scram_state *state)
 /*
- * Determinisitcally generate salt for mock authentication, using a SHA256
+ * Deterministically generate salt for mock authentication, using a SHA256
  * hash based on the username and a cluster-level secret key.  Returns a
  * pointer to a static buffer of size SCRAM_DEFAULT_SALT_LEN.
  */

Thanks,
--
Michael

Attachments:

scram-typo.patchapplication/octet-stream; name=scram-typo.patchDownload
diff --git a/src/backend/libpq/auth-scram.c b/src/backend/libpq/auth-scram.c
index 9161c885e1..ec4bb9a88e 100644
--- a/src/backend/libpq/auth-scram.c
+++ b/src/backend/libpq/auth-scram.c
@@ -1116,7 +1116,7 @@ build_server_final_message(scram_state *state)
 
 
 /*
- * Determinisitcally generate salt for mock authentication, using a SHA256
+ * Deterministically generate salt for mock authentication, using a SHA256
  * hash based on the username and a cluster-level secret key.  Returns a
  * pointer to a static buffer of size SCRAM_DEFAULT_SALT_LEN.
  */
#2Stephen Frost
sfrost@snowman.net
In reply to: Michael Paquier (#1)
Re: Typo in auth-scram.c

Michael,

* Michael Paquier (michael.paquier@gmail.com) wrote:

auth-scram.c is visibly not able to do things in a deterministic way,
that's more determinisitc:

Hah, excellent point, will push in a moment (also to test that the
-committers list is happy with the change to pglister :).

Thanks!

Stephen

#3Michael Paquier
michael.paquier@gmail.com
In reply to: Stephen Frost (#2)
Re: Typo in auth-scram.c

On Mon, Nov 13, 2017 at 10:37 PM, Stephen Frost <sfrost@snowman.net> wrote:

* Michael Paquier (michael.paquier@gmail.com) wrote:

auth-scram.c is visibly not able to do things in a deterministic way,
that's more determinisitc:

Hah, excellent point, will push in a moment (also to test that the
-committers list is happy with the change to pglister :).

Thanks, Stephen.
--
Michael