has_sequence_privilege() never got the memo
I just noticed that has_sequence_privilege() never got the memo about
"WITH GRANT OPTION". Any objections to the attached going back to all
supported versions?
Joe
--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development
Attachments:
2017.11.22.000-seq_privs-missing_grantopt.difftext/x-patch; name=2017.11.22.000-seq_privs-missing_grantopt.diffDownload
diff --git a/src/backend/utils/adt/acl.c b/src/backend/utils/adt/acl.c
index fa6b792..2f2758f 100644
*** a/src/backend/utils/adt/acl.c
--- b/src/backend/utils/adt/acl.c
*************** convert_sequence_priv_string(text *priv_
*** 2242,2249 ****
--- 2242,2252 ----
{
static const priv_map sequence_priv_map[] = {
{"USAGE", ACL_USAGE},
+ {"USAGE WITH GRANT OPTION", ACL_GRANT_OPTION_FOR(ACL_USAGE)},
{"SELECT", ACL_SELECT},
+ {"SELECT WITH GRANT OPTION", ACL_GRANT_OPTION_FOR(ACL_SELECT)},
{"UPDATE", ACL_UPDATE},
+ {"UPDATE WITH GRANT OPTION", ACL_GRANT_OPTION_FOR(ACL_UPDATE)},
{NULL, 0}
};
Joe Conway <mail@joeconway.com> writes:
I just noticed that has_sequence_privilege() never got the memo about
"WITH GRANT OPTION". Any objections to the attached going back to all
supported versions?
That looks odd. Patch certainly makes this case consistent with the
rest of acl.c, but maybe there's some deeper reason? Peter?
regards, tom lane
On 11/22/17 22:58, Tom Lane wrote:
Joe Conway <mail@joeconway.com> writes:
I just noticed that has_sequence_privilege() never got the memo about
"WITH GRANT OPTION". Any objections to the attached going back to all
supported versions?That looks odd. Patch certainly makes this case consistent with the
rest of acl.c, but maybe there's some deeper reason? Peter?
No I think it was just forgotten.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 11/23/2017 07:16 AM, Peter Eisentraut wrote:
On 11/22/17 22:58, Tom Lane wrote:
Joe Conway <mail@joeconway.com> writes:
I just noticed that has_sequence_privilege() never got the memo about
"WITH GRANT OPTION". Any objections to the attached going back to all
supported versions?That looks odd. Patch certainly makes this case consistent with the
rest of acl.c, but maybe there's some deeper reason? Peter?No I think it was just forgotten.
Pushed.
Joe
--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development