pgsql: Prohibit identity columns on typed tables and partitions

Started by Peter Eisentrautabout 8 years ago5 messages

peter_e@gmx.net

about 8 years ago

Prohibit identity columns on typed tables and partitions

Those cases currently crash and supporting them is more work then
originally thought, so we'll just prohibit these scenarios for now.

Author: Michael Paquier <michael.paquier@gmail.com>
Reviewed-by: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Reported-by: Мансур Галиев <gomer94@yandex.ru>
Bug: #14866

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/005ac298b1bdc3e9bd19e5ee2bcf7e320ebe4130

Modified Files
--------------
src/backend/parser/parse_utilcmd.c | 13 +++++++++++++
src/test/regress/expected/identity.out | 12 ++++++++++++
src/test/regress/sql/identity.sql | 16 ++++++++++++++++
3 files changed, 41 insertions(+)

Michael Paquier

michael.paquier@gmail.com

about 8 years ago

In reply to: Peter Eisentraut (#1)

1 attachment(s)

Re: pgsql: Prohibit identity columns on typed tables and partitions

On Sat, Dec 9, 2017 at 2:26 AM, Peter Eisentraut <peter_e@gmx.net> wrote:

Prohibit identity columns on typed tables and partitions

Those cases currently crash and supporting them is more work then
originally thought, so we'll just prohibit these scenarios for now.

+                               (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+                                errmsg("identify columns are not
supported on partitions")));
Er... s/identify/identity/. My fault I guess.
-- 
Michael

Attachments:

identity-errmsg-typo.patchapplication/octet-stream; name=identity-errmsg-typo.patchDownload

diff --git a/src/backend/parser/parse_utilcmd.c b/src/backend/parser/parse_utilcmd.c
index 343e6b3738..f67379f8ed 100644
--- a/src/backend/parser/parse_utilcmd.c
+++ b/src/backend/parser/parse_utilcmd.c
@@ -672,7 +672,7 @@ transformColumnDefinition(CreateStmtContext *cxt, ColumnDef *column)
 					if (cxt->partbound)
 						ereport(ERROR,
 								(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-								 errmsg("identify columns are not supported on partitions")));
+								 errmsg("identity columns are not supported on partitions")));
 
 					ctype = typenameType(cxt->pstate, column->typeName, NULL);
 					typeOid = HeapTupleGetOid(ctype);

Magnus Hagander

magnus@hagander.net

about 8 years ago

In reply to: Michael Paquier (#2)

Re: pgsql: Prohibit identity columns on typed tables and partitions

On Sat, Dec 9, 2017 at 8:43 AM, Michael Paquier <michael.paquier@gmail.com>
wrote:

On Sat, Dec 9, 2017 at 2:26 AM, Peter Eisentraut <peter_e@gmx.net> wrote:

Prohibit identity columns on typed tables and partitions

Those cases currently crash and supporting them is more work then
originally thought, so we'll just prohibit these scenarios for now.
+                               (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+                                errmsg("identify columns are not
supported on partitions")));
Er... s/identify/identity/. My fault I guess.

Spotted the separate report on it first, so a fix has been pushed.

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Peter Eisentraut

peter.eisentraut@2ndquadrant.com

about 8 years ago

In reply to: Magnus Hagander (#3)

Re: pgsql: Prohibit identity columns on typed tables and partitions

On 12/9/17 05:47, Magnus Hagander wrote:

On Sat, Dec 9, 2017 at 8:43 AM, Michael Paquier
<michael.paquier@gmail.com <mailto:michael.paquier@gmail.com>> wrote:

On Sat, Dec 9, 2017 at 2:26 AM, Peter Eisentraut <peter_e@gmx.net
<mailto:peter_e@gmx.net>> wrote:

Prohibit identity columns on typed tables and partitions

Those cases currently crash and supporting them is more work then
originally thought, so we'll just prohibit these scenarios for now.
+                               (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+                                errmsg("identify columns are not
supported on partitions")));
Er... s/identify/identity/. My fault I guess.
Spotted the separate report on it first, so a fix has been pushed.

Please also backpatch to PG10.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Magnus Hagander

magnus@hagander.net

about 8 years ago

In reply to: Peter Eisentraut (#4)

Re: pgsql: Prohibit identity columns on typed tables and partitions

On Sat, Dec 9, 2017 at 10:45 PM, Peter Eisentraut <
peter.eisentraut@2ndquadrant.com> wrote:

On 12/9/17 05:47, Magnus Hagander wrote:

On Sat, Dec 9, 2017 at 8:43 AM, Michael Paquier
<michael.paquier@gmail.com <mailto:michael.paquier@gmail.com>> wrote:

On Sat, Dec 9, 2017 at 2:26 AM, Peter Eisentraut <peter_e@gmx.net
<mailto:peter_e@gmx.net>> wrote:

Prohibit identity columns on typed tables and partitions

Those cases currently crash and supporting them is more work then
originally thought, so we'll just prohibit these scenarios for now.

+ (errcode(ERRCODE_FEATURE_NOT_

SUPPORTED),

+ errmsg("identify columns are not
supported on partitions")));
Er... s/identify/identity/. My fault I guess.

Spotted the separate report on it first, so a fix has been pushed.

Please also backpatch to PG10.

Oops, I completely missed that the original patch was backpatched. Will
fix, thanks!

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>