Mar 2024

1 commit
Fix unstable aggregate regression test
27 Mar 2024David Rowleymaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1REL_16_STABLE16.3
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The attachment in #76 adds sleeps to reproduce autovacuum-induced plan instability, whereas d6a6957d53 adds autovacuum_enabled = off to pagg_test in the SQL and expected output. David Rowley explains his choice of this fix in #77.

  • Alexander Lakhinsaw the final versionLLM analysis, 99% sureBefore the commit, Alexander reproduced the intermittent plan change and identified automatic analyze as its cause in #76, supplying the diagnosis accepted for the fix.

Jan 2023

1 commit
Allow parallel aggregate on string_agg and array_agg
23 Jan 2023David Rowleymaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #672 of 4 reviewers saw the final version

Compared with #67, 16fd03e956 only moves three loop-index declarations into for statements in array_userfuncs.c and adds the catalog-version bump, apart from rebase and whitespace differences. The tests and documentation changes match.

  • Andres Freundsaw an earlier versiontrailerHis initial inspection in #3 proposed fn_extra caching, adopted in #5, before subsequent NULL-handling, receive-buffer and planner corrections.
  • Tomas Vondrasaw the final versiontrailerTomas reviewed and tested successive versions, corrected the planner safeguard and endorsed #50 in #51, after which the remaining changes were rebase adaptations and light cleanup.
  • Stephen Frostsaw an earlier versiontrailerStephen identified invalid copying and serialization of NULL datums in #15, before the NULL fixes, receive-buffer changes and planner safeguard were implemented.
  • Tom Lanesaw the final versiontrailerTom supplied the revised implementation in #19, helped refine the serialization safeguard in #42 and reconsidered the final submission's ordering tradeoffs in #68.

Credits across 2 commits

Author
David Rowley1
Reviewer
Andres Freund1
Stephen Frost1
Tom Lane1
Tomas Vondra1
Reported by
Alexander Lakhin1
Committer
David Rowley2