May 2021

1 commit
Tighten the concurrent abort check during decoding.
6 May 2021Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surelanded as postedfrom patchset #5601 of 1 reviewer saw the final version

The reorderbuffer.c change exactly matches #560: require stream_started or a prepared transaction before treating the rollback error as a concurrent abort.

  • Dilip Kumarsaw the final versiontrailerReviewed the posted fix in #561, after discussing why the rollback error needs a stronger guard.

Dec 2020

2 commits
Improve hash_create()'s API for some added robustness.
15 Dec 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #5551 of 1 reviewer saw the final version

The rolled-up hash_create API changes in #555 match the commit except for three documentation lines, including Noah's requested should-to-must correction.

  • Noah Mischsaw the final versionLLM analysis, 99% sureRequested the specific documentation correction in #556, which Tom accepted in #557 and included in the commit.
Use HASH_BLOBS for xidhash.
13 Dec 2020Noah Mischmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 98% suremodified before commitmoderate changesfrom patchset #547

Retains the HASH_BLOBS correction and multi-stream test from #547, but reworks the PostgresNode.pm helper into background_psql with documentation, startup synchronization and timeout handling.

Jul - Sep 2020

12 commits
Fix initialization of RelationSyncEntry for streaming transactions.
16 Sep 2020Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surelanded as postedfrom patchset #5380 of 2 reviewers saw the final version

The pgoutput.c initialization and validation split, NIL initialization and memory-context cleanup exactly match #538.

  • Tom Lanesaw an earlier versiontrailerProposed separating initialization from validation in #535 and explained hash-entry lifetime in #537, before the local logic was reworked in #538.
  • Dilip Kumarsaw an earlier versiontrailerReproduced the callback failure with gdb and verified the first fix in #534, before the initialization and validation rewrite.
Remove unused function declaration in logicalproto.h.
12 Sep 2020Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surelanded as postedfrom patchset #5232 of 2 reviewers saw the final version

Both hunks from #523 match: remove logicalrep_read_stream_stop from logicalproto.h and fix the pgoutput.c typo.

  • Dilip Kumarsaw the final versiontrailerReviewed the cleanup in #524; the committed hunks are unchanged.
  • Amit Kapilasaw the final versioncommittercommitted the patch
Add additional tests to test streaming of in-progress transactions.
7 Sep 2020Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surelanded as postedfrom patchset #5181 of 1 reviewer saw the final version

The four subscription TAP test files exactly match #518; its Author credit identifies Tomas Vondra, Amit Kapila and Dilip Kumar.

  • Dilip Kumarsaw the final versiontrailerExplicitly reviewed the revised additional tests in #519 before they were committed.
Fix inline marking introduced in commit 464824323e.
4 Sep 2020Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surewritten from the discussion, no matching patch

Nathan Bossart supplied the inline changes_filename declaration fix in #516; Amit extended inline marking to subxact_filename in #517, with no matching indexed attachment.

Add support for streaming to built-in logical replication.
3 Sep 2020Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #5141 of 3 reviewers saw the final version

The subscriber, protocol and pgoutput implementation matches #514, with an additional catalog-version bump; the patch credits Tomas Vondra, Dilip Kumar and Amit Kapila.

  • Amit Kapilasaw the final versiontrailerReviewed subscriber cleanup, schema tracking and tests, prepared #514, and committed the final version.
  • Kuntal Ghoshsaw an earlier versiontrailerReviewed worker file-error handling and missing pg_dump support in #263, before BufFile and schema-tracking revisions.
  • Ajin Cheriansaw an earlier versiontrailerTested archive-only full-series revisions in #409 and #459, before substantial subscriber cleanup and schema-tracking changes; those reviewed archives have no indexed patchset IDs.
Fix the SharedFileSetUnregister API.
1 Sep 2020Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #5061 of 1 reviewer saw the final version

The first patch in #506 matches the SharedFileSet unregister/list-traversal fix exactly; the second subscriber patch was committed separately.

  • Dilip Kumarsaw the final versiontrailerReviewed the unregister correction in #502 and added a targeted test in #506.
Extend the BufFile interface.
26 Aug 2020Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #4951 of 1 reviewer saw the final version

The first patch of #495 matches the BufFile and SharedFileSet interface changes modulo hunk alignment; subscriber and test components remain outside this commit.

  • Amit Kapilasaw the final versiontrailerReviewed truncation state, dirty buffers and cleanup, prepared #495, and committed the final implementation.
Mark a few logical decoding related variables with PGDLLIMPORT.
15 Aug 2020Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surewritten from the discussion, no matching patch

Thomas Munro diagnosed missing PGDLLIMPORT declarations for CheckXidAlive and bsysscan in #470; Amit applied the two declaration changes and confirmed the commit in #473.

Implement streaming mode in ReorderBuffer.
8 Aug 2020Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 98% suremodified before commitlight changesfrom patchset #4642 of 3 reviewers saw the final version

The backend implementation in #464 matches after comment/pgindent cleanup and the spill-then-stream TOAST regression test added in #465 and refined in #466.

  • Amit Kapilasaw the final versiontrailerReviewed the streaming and abort algorithms, prepared #464, refined the final regression test in #466, and committed the result.
  • Kuntal Ghoshsaw an earlier versiontrailerReviewed concurrent-abort error cleanup, snapshot handling and memory contexts in #252, before substantial ReorderBuffer restructuring.
  • Ajin Cheriansaw the final versiontrailerTested the archive-only version posted in #458 and reported results in #459; only comments, redundant assignment removal and tests changed before landing, and that archive has no indexed patchset ID.
Extend the logical decoding output plugin API with stream methods.
28 Jul 2020Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #3981 of 1 reviewer saw the final version

Takes the output-plugin API component from #398, adding include_xids/include_timestamp handling in test_decoding and documentation/function-order cleanup described in #452.

  • Amit Kapilasaw the final versiontrailerPrepared the callback patch in #398, reviewed output-option behavior in #452, and committed the final API.
WAL Log invalidations at command end with wal_level=logical.
23 Jul 2020Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% suremodified before commitmoderate changesfrom patchset #4021 of 1 reviewer saw the final version

Derives from #402, but marks catalog changes during fast-forward decoding, reuses xl_xact_invals instead of adding a duplicate structure, and bumps WAL magic.

  • Amit Kapilasaw the final versiontrailerReviewed invalidation collection and commit-time logging, required the fast-forward fix in #447, and committed the final patch.
Immediately WAL-log subtransaction and top-level XID association.
20 Jul 2020Amit Kapilamaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #3981 of 1 reviewer saw the final version

The assignment component of #398 matches the commit apart from the WAL-magic bump; later indexed submissions do not repost this component.

  • Amit Kapilasaw the final versiontrailerReworked and regression-tested the prerequisite in #353, carried it through #398, and committed the final version.

Nov 2019

2 commits
Track statistics for spilling of changes from ReorderBuffer.
21 Nov 2019Amit Kapilamaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #1421 of 1 reviewer saw the final version

The statistics component last reposted in #142 matches the committed files, with only a catalog-version bump added; its Author credit names Tomas Vondra with Dilip's fixes.

  • Amit Kapilasaw the final versiontrailerReviewed spill-counter semantics and types, prepared #137, and committed the statistics component reposted in #142.
Add logical_decoding_work_mem to limit ReorderBuffer memory usage.
19 Nov 2019Amit Kapilamaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #1372 of 2 reviewers saw the final version

The memory-limit component of #137 has identical resulting file content; the accompanying statistics patch was committed separately, and the Author credit names Tomas Vondra with Dilip and Amit's changes.

  • Dilip Kumarsaw the final versiontrailerReviewed the memory-limit corrections in #126, after which only light preparation changes led to #137.
  • Amit Kapilasaw the final versiontrailerReviewed accounting and configuration behavior, prepared #125 and #137, and committed the final memory-limit patch.

Credits across 17 commits

Author
Amit Kapila11
Tomas Vondra9
Dilip Kumar7
minor changes by Dilip Kumar1
Nikhil Sontakke1
Noah MischLLM1
Tom LaneLLM1
with bug-fixes1
with changes by Dilip Kumar1
Reviewer
Amit Kapilacommitter9
Dilip Kumar6
Ajin Cherian2
Kuntal Ghosh2
Tom Lane1
Tested by
Neha Sharma7
Mahendra Singh Thalor5
Ajin Cherian2
Dilip Kumar1
vignesh C1
Reported by
Nathan Bossart1
Thomas Munro1
Tom Lane1
Tomas Vondra1
Committer
Amit Kapila15
Noah Misch1
Tom Lane1

N LLM means N of the credits come from LLM analysis, not from commit trailers.