A typo in error message

Started by Alexander Lakhinalmost 8 years ago3 messages

Alexander Lakhin

exclusion@gmail.com

almost 8 years ago

1 attachment(s)

Hello,

Please consider committing the attached patch to fix a typo in error
message.

Best regards,

--
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachments:

colums.patchtext/x-patch; name=colums.patchDownload

diff --git a/src/backend/parser/parse_utilcmd.c b/src/backend/parser/parse_utilcmd.c
index e0d96d7..4894812 100644
--- a/src/backend/parser/parse_utilcmd.c
+++ b/src/backend/parser/parse_utilcmd.c
@@ -668,7 +668,7 @@ transformColumnDefinition(CreateStmtContext *cxt, ColumnDef *column)
 					if (cxt->ofType)
 						ereport(ERROR,
 									(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-									 errmsg("identity colums are not supported on typed tables")));
+									 errmsg("identity columns are not supported on typed tables")));
 					if (cxt->partbound)
 						ereport(ERROR,
 								(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
diff --git a/src/test/regress/expected/identity.out b/src/test/regress/expected/identity.out
index 87ef0d3..627389b 100644
--- a/src/test/regress/expected/identity.out
+++ b/src/test/regress/expected/identity.out
@@ -349,7 +349,7 @@ DROP USER regress_user1;
 -- typed tables (currently not supported)
 CREATE TYPE itest_type AS (f1 integer, f2 text, f3 bigint);
 CREATE TABLE itest12 OF itest_type (f1 WITH OPTIONS GENERATED ALWAYS AS IDENTITY); -- error
-ERROR:  identity colums are not supported on typed tables
+ERROR:  identity columns are not supported on typed tables
 DROP TYPE itest_type CASCADE;
 -- table partitions (currently not supported)
 CREATE TABLE itest_parent (f1 date NOT NULL, f2 text, f3 bigint) PARTITION BY RANGE (f1);

Michael Paquier

michael.paquier@gmail.com

almost 8 years ago

In reply to: Alexander Lakhin (#1)

Re: A typo in error message

On Wed, Jan 31, 2018 at 08:47:57AM +0300, Alexander Lakhin wrote:

Please consider committing the attached patch to fix a typo in error
message.

Yeah..

if (cxt->ofType)
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-                             	 errmsg("identity colums are not supported on typed tables")));
+                             	 errmsg("identity columns are not supported on typed tables")));
if (cxt->partbound)
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),

The indentation for this ereport() is weird as well here.
--
Michael

Robert Haas

robertmhaas@gmail.com

almost 8 years ago

In reply to: Michael Paquier (#2)

Re: A typo in error message

On Wed, Jan 31, 2018 at 12:53 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:

On Wed, Jan 31, 2018 at 08:47:57AM +0300, Alexander Lakhin wrote:

Please consider committing the attached patch to fix a typo in error
message.

Yeah..

Committed.

if (cxt->ofType)
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-                                      errmsg("identity colums are not supported on typed tables")));
+                                      errmsg("identity columns are not supported on typed tables")));
if (cxt->partbound)
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),

The indentation for this ereport() is weird as well here.

Hit it with pgindent to fix this, too.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company