A typo in error message

Started by Alexander Lakhinabout 8 years ago3 messageshackers
Jump to latest
#1Alexander Lakhin
exclusion@gmail.com

Hello,

Please consider committing the attached patch to fix a typo in error
message.

Best regards,

--
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachments:

colums.patchtext/x-patch; name=colums.patchDownload+2-2
#2Michael Paquier
michael@paquier.xyz
In reply to: Alexander Lakhin (#1)
Re: A typo in error message

On Wed, Jan 31, 2018 at 08:47:57AM +0300, Alexander Lakhin wrote:

Please consider committing the attached patch to fix a typo in error
message.

Yeah..

if (cxt->ofType)
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-                             	 errmsg("identity colums are not supported on typed tables")));
+                             	 errmsg("identity columns are not supported on typed tables")));
if (cxt->partbound)
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),

The indentation for this ereport() is weird as well here.
--
Michael

#3Robert Haas
robertmhaas@gmail.com
In reply to: Michael Paquier (#2)
Re: A typo in error message

On Wed, Jan 31, 2018 at 12:53 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:

On Wed, Jan 31, 2018 at 08:47:57AM +0300, Alexander Lakhin wrote:

Please consider committing the attached patch to fix a typo in error
message.

Yeah..

Committed.

if (cxt->ofType)
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-                                      errmsg("identity colums are not supported on typed tables")));
+                                      errmsg("identity columns are not supported on typed tables")));
if (cxt->partbound)
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),

The indentation for this ereport() is weird as well here.

Hit it with pgindent to fix this, too.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company