Python 3.7 support

Started by Peter Eisentrautabout 8 years ago6 messageshackers
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

A small patch to tweak the tests to support output differences with
Python 3.7 (currently in beta).

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachments:

0001-Tweak-tests-to-support-Python-3.7.patchtext/plain; charset=UTF-8; name=0001-Tweak-tests-to-support-Python-3.7.patch; x-mac-creator=0; x-mac-type=0Download+4-5
#2Michael Paquier
michael@paquier.xyz
In reply to: Peter Eisentraut (#1)
Re: Python 3.7 support

On Tue, Feb 13, 2018 at 04:17:13PM -0500, Peter Eisentraut wrote:

A small patch to tweak the tests to support output differences with
Python 3.7 (currently in beta).

Wouldn't it be better to wait for the version to be released before
pushing anything in the tree? If there are again changes when this
comes out as GA then an extra patch would be needed.
--
Michael

#3Peter Eisentraut
peter_e@gmx.net
In reply to: Michael Paquier (#2)
Re: Python 3.7 support

On 2/13/18 21:45, Michael Paquier wrote:

On Tue, Feb 13, 2018 at 04:17:13PM -0500, Peter Eisentraut wrote:

A small patch to tweak the tests to support output differences with
Python 3.7 (currently in beta).

Wouldn't it be better to wait for the version to be released before
pushing anything in the tree? If there are again changes when this
comes out as GA then an extra patch would be needed.

Sure, we can just leave it here for the record until the release comes
closer.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

#4Peter Eisentraut
peter_e@gmx.net
In reply to: Peter Eisentraut (#3)
Re: Python 3.7 support

On 2/14/18 21:25, Peter Eisentraut wrote:

On 2/13/18 21:45, Michael Paquier wrote:

On Tue, Feb 13, 2018 at 04:17:13PM -0500, Peter Eisentraut wrote:

A small patch to tweak the tests to support output differences with
Python 3.7 (currently in beta).

Wouldn't it be better to wait for the version to be released before
pushing anything in the tree? If there are again changes when this
comes out as GA then an extra patch would be needed.

Sure, we can just leave it here for the record until the release comes
closer.

I have committed this now, since the release of Python 3.7 is soon.
I'll let the build farm have a pass at it, then backport it for the
upcoming minor releases.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

#5Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#4)
Re: Python 3.7 support

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:

I have committed this now, since the release of Python 3.7 is soon.
I'll let the build farm have a pass at it, then backport it for the
upcoming minor releases.

gaur/pademelon (Python 2.5) not very happy :-(. Let me know if you'd
like me to try anything particular there.

regards, tom lane

#6Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#4)
Re: Python 3.7 support

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:

I have committed this now, since the release of Python 3.7 is soon.
I'll let the build farm have a pass at it, then backport it for the
upcoming minor releases.

If you're intending to push this into the back branches before Monday's
releases, please do it *today*, the sooner the better. We are rapidly
closing in on the point where we'd not have a full set of buildfarm runs
done before the wrap. That is not a good situation for a patch with
portability implications.

regards, tom lane