Nov 2019

3 commits
Refactor reloption handling for index AMs in-core
25 Nov 2019Michael Paquiermaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #712 of 4 reviewers saw the final version

The commit matches the index structures, build_reloptions() calls and assertions in #71, with an updated StdRdOptions comment, formatting and three additions to src/tools/pgindent/typedefs.list. Michael posted that revision of Nikolay's work, and the commit explicitly credits Nikolay as author.

  • Amit Langotesaw the final versiontrailerAmit identified duplicated parsing code in #42 and reviewed the final patch in #74, requesting the StdRdOptions comment correction that landed.
  • Michael Paquiersaw the final versiontrailerMichael reviewed the broad patch in #34, requested index assertions in #68, supplied the final revision in #71 and committed it.
  • Álvaro Herrerasaw an earlier versiontrailerÁlvaro challenged API renaming, new relation-kind macros and abstraction boundaries in #11, #17 and #26, before the scope reduction and later parsing refactor.
  • Dent Johnsaw an earlier versiontrailerDent reported build failures in #27, tested the update in #31 and examined the index parsing tables in #38, before wrapper conversion and AM assertions.
Cleanup code in reloptions.h regarding reloption handling
14 Nov 2019Michael Paquiermaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #63

The commit implements the macro removal and helper privatization from #63, but retains GET_STRING_RELOPTION() and updates comments in src/include/access/reloptions.h. Michael explicitly confirms that retention in #67.

Refactor code building relation options
5 Nov 2019Michael Paquiermaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #551 of 1 reviewer saw the final version

The commit takes build_reloptions() and all caller conversions from #55, while omitting the changes making parseRelOptions(), allocateReloptStruct() and fillRelOptions() private. It also relocates the wrapper and adjusts comments; Michael explains the deliberate API retention in #57.

  • Michael Paquiersaw the final versiontrailerMichael reviewed naming and API details, tested dummy_index_am and replaced the broken assertion in #52, then adjusted and committed the final patch as reported in #57.

Credits across 3 commits

Author
Amit Langote1
Michael PaquierLLM1
Nikolay Shaplov1
Reviewer
Michael Paquier2
Alvaro Herrera1
Amit Langote1
Dent John1
Committer
Michael Paquier3

N LLM means N of the credits come from LLM analysis, not from commit trailers.