initdb help message about WAL segment size

Started by Magnus Haganderalmost 8 years ago2 messages
#1Magnus Hagander
magnus@hagander.net
1 attachment(s)

I propose the attached patch, aligning the help message with the docs. Any
reason not to?

(yes, I confused myself by trying --wal-segsize=1MB instead of just
--wal-segsize=1. I blame just stepping off an intercontinental flight and a
very early morning :P)

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/&gt;
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/&gt;

Attachments:

walsegsize.patchtext/x-patch; charset=US-ASCII; name=walsegsize.patchDownload
diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
index 1f7f2aaa54..65eba7d42f 100644
--- a/src/bin/initdb/initdb.c
+++ b/src/bin/initdb/initdb.c
@@ -2323,7 +2323,7 @@ usage(const char *progname)
 	printf(_("  -U, --username=NAME       database superuser name\n"));
 	printf(_("  -W, --pwprompt            prompt for a password for the new superuser\n"));
 	printf(_("  -X, --waldir=WALDIR       location for the write-ahead log directory\n"));
-	printf(_("      --wal-segsize=SIZE    size of wal segment size\n"));
+	printf(_("      --wal-segsize=SIZE    size of wal segment size in megabytes\n"));
 	printf(_("\nLess commonly used options:\n"));
 	printf(_("  -d, --debug               generate lots of debugging output\n"));
 	printf(_("  -k, --data-checksums      use data page checksums\n"));
#2Michael Paquier
michael@paquier.xyz
In reply to: Magnus Hagander (#1)
Re: initdb help message about WAL segment size

On Sun, Mar 11, 2018 at 08:23:39AM +0100, Magnus Hagander wrote:

I propose the attached patch, aligning the help message with the docs. Any
reason not to?

+1 for doing what you are suggesting.
--
Michael