Typo in shared_record_table_compare() commentary

Started by Arthur Zakirovalmost 8 years ago3 messages
#1Arthur Zakirov
a.zakirov@postgrespro.ru
1 attachment(s)

Hello hackers,

During studying dshash I've found a little typo. There is no
SharedRecordTableKey struct in the code, I think the commentary refers
to SharedRecordTableKey struct.

The patch is attached.

--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

Attachments:

typcache-typo.patchtext/plain; charset=us-asciiDownload
diff --git a/src/backend/utils/cache/typcache.c b/src/backend/utils/cache/typcache.c
index 874d8cd1c9..e38fd16eb0 100644
--- a/src/backend/utils/cache/typcache.c
+++ b/src/backend/utils/cache/typcache.c
@@ -198,7 +198,7 @@ typedef struct SharedTypmodTableEntry
 } SharedTypmodTableEntry;
 
 /*
- * A comparator function for SharedTupleDescTableKey.
+ * A comparator function for SharedRecordTableKey.
  */
 static int
 shared_record_table_compare(const void *a, const void *b, size_t size,
#2Thomas Munro
thomas.munro@enterprisedb.com
In reply to: Arthur Zakirov (#1)
Re: Typo in shared_record_table_compare() commentary

On Thu, Mar 29, 2018 at 10:16 PM, Arthur Zakirov
<a.zakirov@postgrespro.ru> wrote:

During studying dshash I've found a little typo. There is no
SharedRecordTableKey struct in the code, I think the commentary refers
to SharedRecordTableKey struct.

Right, thanks!

The patch is attached.

+1

--
Thomas Munro
http://www.enterprisedb.com

#3Magnus Hagander
magnus@hagander.net
In reply to: Thomas Munro (#2)
Re: Typo in shared_record_table_compare() commentary

On Thu, Mar 29, 2018 at 11:37 AM, Thomas Munro <
thomas.munro@enterprisedb.com> wrote:

On Thu, Mar 29, 2018 at 10:16 PM, Arthur Zakirov
<a.zakirov@postgrespro.ru> wrote:

During studying dshash I've found a little typo. There is no
SharedRecordTableKey struct in the code, I think the commentary refers
to SharedRecordTableKey struct.

Right, thanks!

The patch is attached.

+1

Applied, thanks.

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/&gt;
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/&gt;