Typo in shared_record_table_compare() commentary
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t38459psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 28, 2026 at 02:03 PM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t38459_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t38459_1 && git checkout t38459_1Patchset v1 (message #1) is on t38459_1
Hello hackers,
During studying dshash I've found a little typo. There is no
SharedRecordTableKey struct in the code, I think the commentary refers
to SharedRecordTableKey struct.
The patch is attached.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
On Thu, Mar 29, 2018 at 10:16 PM, Arthur Zakirov
<a.zakirov@postgrespro.ru> wrote:
During studying dshash I've found a little typo. There is no
SharedRecordTableKey struct in the code, I think the commentary refers
to SharedRecordTableKey struct.
Right, thanks!
The patch is attached.
+1
--
Thomas Munro
http://www.enterprisedb.com
On Thu, Mar 29, 2018 at 11:37 AM, Thomas Munro <
thomas.munro@enterprisedb.com> wrote:
On Thu, Mar 29, 2018 at 10:16 PM, Arthur Zakirov
<a.zakirov@postgrespro.ru> wrote:During studying dshash I've found a little typo. There is no
SharedRecordTableKey struct in the code, I think the commentary refers
to SharedRecordTableKey struct.Right, thanks!
The patch is attached.
+1
Applied, thanks.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>