JIT flag definitions not parenthesized

Started by David Rowleyalmost 8 years ago3 messageshackers
Jump to latest
#1David Rowley
dgrowleyml@gmail.com

Looks like the JIT flags definitions are not properly parenthesized.
It might not matter too much for their current usage, but it might
save a bit of confusion later.

git grep "^#define .*<<.*[^)]$" indicates these are the only offenders.

Patch attached.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachments:

parenthesize_jit_flags.patchapplication/octet-stream; name=parenthesize_jit_flags.patchDownload+5-5
#2Heikki Linnakangas
heikki.linnakangas@enterprisedb.com
In reply to: David Rowley (#1)
Re: JIT flag definitions not parenthesized

On 22/04/18 23:21, David Rowley wrote:

Looks like the JIT flags definitions are not properly parenthesized.
It might not matter too much for their current usage, but it might
save a bit of confusion later.

git grep "^#define .*<<.*[^)]$" indicates these are the only offenders.

Patch attached.

Fixed, thanks!

- Heikki

#3Andres Freund
andres@anarazel.de
In reply to: Heikki Linnakangas (#2)
Re: JIT flag definitions not parenthesized

Hi,

On 2018-04-23 04:49:17 -0400, Heikki Linnakangas wrote:

On 22/04/18 23:21, David Rowley wrote:

Patch attached.

Fixed, thanks!

Thanks David, Heikki.

- Andres