Typo in JIT documentation

Started by Michael Paquierover 8 years ago4 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t38605
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 27, 2026 at 08:36 PM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t38605_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t38605_1 && git checkout t38605_1

Patchset v1 (message #1) is on t38605_1

Jump to latest
#1Michael Paquier
michael@paquier.xyz

Hi all,

I just found $subject:
     the server was compiled without <literal>--with-llvm</literal>),
-    <acronym>JIT</acronym> will not performed, even if considered to be
+    <acronym>JIT</acronym> will not be performed, even if considered to be
     beneficial based on the above criteria.  Setting <xref linkend="guc-jit"/>

Thanks,
--
Michael

Attachments:

t38605_1
jit-typo.patchtext/x-diff; charset=us-asciiDownload+1-1
#2Magnus Hagander
magnus@hagander.net
In reply to: Michael Paquier (#1)
Re: Typo in JIT documentation

On Wed, Apr 25, 2018 at 4:11 AM, Michael Paquier <michael@paquier.xyz>
wrote:

Hi all,

I just found $subject:
the server was compiled without <literal>--with-llvm</literal>),
-    <acronym>JIT</acronym> will not performed, even if considered to be
+    <acronym>JIT</acronym> will not be performed, even if considered to be
beneficial based on the above criteria.  Setting <xref
linkend="guc-jit"/>

Applied, thanks.

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/&gt;
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/&gt;

#3Robert Haas
robertmhaas@gmail.com
In reply to: Magnus Hagander (#2)
Re: Typo in JIT documentation

On Wed, Apr 25, 2018 at 3:30 AM, Magnus Hagander <magnus@hagander.net> wrote:

On Wed, Apr 25, 2018 at 4:11 AM, Michael Paquier <michael@paquier.xyz>
wrote:

Hi all,

I just found $subject:
the server was compiled without <literal>--with-llvm</literal>),
-    <acronym>JIT</acronym> will not performed, even if considered to be
+    <acronym>JIT</acronym> will not be performed, even if considered to
be
beneficial based on the above criteria.  Setting <xref
linkend="guc-jit"/>

Applied, thanks.

Hmm, I thought we talked about changing such references to say 'JIT
compilation' rather than just 'JIT'.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

#4Michael Paquier
michael@paquier.xyz
In reply to: Robert Haas (#3)
Re: Typo in JIT documentation

On Thu, Apr 26, 2018 at 02:50:51PM -0400, Robert Haas wrote:

Hmm, I thought we talked about changing such references to say 'JIT
compilation' rather than just 'JIT'.

Perhaps. I recall that this has been mentioned already the last couple
of weeks on the JIT thread. Personally, I can see that JIT is listed as
an acronym in the docs with its meaning explained by a link to
wikipedia about just-in-time compilation, so I am fine with the use of
the acronym. "JIT" is actually used without the <acronym> markup in
config.sgml. I think that at least this part should be fixed.

At the end that would be mainly Andres' call? Do you think that an open
item would be adapted?
--
Michael