perltidy tweaks
I prpose two tweaks for the perltidy configuration:
- The new perltidy version can avoid writing backup files, so we don't
need to explicitly delete them after.
- Use option --nooutdent-long-quotes. This is similar to a change we
made for pgindent in the C code a while ago. See patch for the results.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachments:
0001-perltidy-Don-t-write-backup-files.patchtext/plain; charset=UTF-8; name=0001-perltidy-Don-t-write-backup-files.patch; x-mac-creator=0; x-mac-type=0Download+1-4
0002-perltidy-Add-option-nooutdent-long-quotes.patchtext/plain; charset=UTF-8; name=0002-perltidy-Add-option-nooutdent-long-quotes.patch; x-mac-creator=0; x-mac-type=0Download+294-288
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
I prpose two tweaks for the perltidy configuration:
- The new perltidy version can avoid writing backup files, so we don't
need to explicitly delete them after.
+1
- Use option --nooutdent-long-quotes. This is similar to a change we
made for pgindent in the C code a while ago. See patch for the results.
No strong opinion as to whether to do that or not, but if we do, I wonder
if we shouldn't also select --nooutdent-long-comments. I noticed a few
places where it was doing that (ie moving comments left if they went past
the right margin) and didn't particularly like it.
What would be more per project style is to reflow overly-wide comments
into multiple lines, but I don't see an option for that :-(
regards, tom lane
On 04/26/2018 12:33 PM, Tom Lane wrote:
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
I prpose two tweaks for the perltidy configuration:
- The new perltidy version can avoid writing backup files, so we don't
need to explicitly delete them after.+1
+1
- Use option --nooutdent-long-quotes. This is similar to a change we
made for pgindent in the C code a while ago. See patch for the results.No strong opinion as to whether to do that or not, but if we do, I wonder
if we shouldn't also select --nooutdent-long-comments. I noticed a few
places where it was doing that (ie moving comments left if they went past
the right margin) and didn't particularly like it.
Yeah, not a fan of the outdenting, so +1 to both of these.
What would be more per project style is to reflow overly-wide comments
into multiple lines, but I don't see an option for that :-(
Right. Maybe we need a script that at least identifies them for us.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 4/26/18 14:10, Andrew Dunstan wrote:
- Use option --nooutdent-long-quotes. This is similar to a change we
made for pgindent in the C code a while ago. See patch for the results.No strong opinion as to whether to do that or not, but if we do, I wonder
if we shouldn't also select --nooutdent-long-comments. I noticed a few
places where it was doing that (ie moving comments left if they went past
the right margin) and didn't particularly like it.Yeah, not a fan of the outdenting, so +1 to both of these.
committed all three
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services