model-writtenrun 9702 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Antonin Houska reported that SnapBuildInitialSnapshot() converted transaction arrays to ordinary MVCC semantics while retaining the historic visibility function, and proposed an inline assignment fixing the mismatch in #1.
- Álvaro Herrera observed that core callers did not use the visibility function in #2; Antonin explained that pg_squeeze encountered the problem while copying table data and capturing concurrent changes through logical decoding in #3 and #5, answering Andres Freund's question in #4.
- After Bruce Momjian urged fixing the oversight in #6, Antonin returned months later with the attached patch in #7, setting SNAPSHOT_MVCC for initial slot snapshots and explicitly initializing the same type when importing snapshots.
- Michael Paquier proposed passing the snapshot type into SnapBuildBuildSnapshot() and questioned the import comment in #8; Antonin argued that a general type argument would misrepresent the function's capabilities and that overwriting fields already matched the existing conversion logic, while accepting comment removal in #9.
- Michael accepted the existing approach in #10, and Álvaro raised no objection in #11; a possible boolean argument was left as separate work rather than included in this bug fix.
- Michael committed 56fadbedbd from #7 with light comment and placement edits, backpatched the fix through PostgreSQL 9.4, and closed the thread with the commit confirmation in #12.