Test patch for partitionwise join with partitioned tables containing default partition

Started by Rajkumar Raghuwanshiover 7 years ago4 messages
#1Rajkumar Raghuwanshi
Rajkumar Raghuwanshi
rajkumar.raghuwanshi@enterprisedb.com
1 attachment(s)

Hi,

As of now partition_join.sql is not having test cases covering cases
where partition table have default partition, attaching a small test
case patch to cover those.

Here is a link of previous discussion :
/messages/by-id/CAKcux6=LO-
XK9G0yLe634%2B0SP2UOn5ksVnmF-OntTBOEEaUGTg%40mail.gmail.com

As found by Thomas, The regression test currently fails with v4 patch
because a
redundant Result node has been removed from a query plan. here is the
updated
v5 patch fixing this.

Thanks & Regards,
Rajkumar Raghuwanshi
QMG, EnterpriseDB Corporation

Attachments:

partitionwise_join_with_default_partitions_v5.patchtext/x-patch; charset=US-ASCII; name=partitionwise_join_with_default_partitions_v5.patch
#2Ashutosh Bapat
Ashutosh Bapat
ashutosh.bapat@enterprisedb.com
In reply to: Rajkumar Raghuwanshi (#1)
Re: Test patch for partitionwise join with partitioned tables containing default partition

Thanks Rajkumar for starting a new thread. Please update the
commitfest entry as well.

I have marked this entry as ready for committer, so expecting a
committer to take a look at the patch and commit it.

On Wed, Jun 6, 2018 at 11:26 AM, Rajkumar Raghuwanshi
<rajkumar.raghuwanshi@enterprisedb.com> wrote:

Hi,

As of now partition_join.sql is not having test cases covering cases
where partition table have default partition, attaching a small test
case patch to cover those.

Here is a link of previous discussion :
/messages/by-id/CAKcux6=LO-XK9G0yLe634+0SP2UOn5ksVnmF-OntTBOEEaUGTg@mail.gmail.com

As found by Thomas, The regression test currently fails with v4 patch
because a
redundant Result node has been removed from a query plan. here is the
updated
v5 patch fixing this.

Thanks & Regards,
Rajkumar Raghuwanshi
QMG, EnterpriseDB Corporation

--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

#3Rajkumar Raghuwanshi
Rajkumar Raghuwanshi
rajkumar.raghuwanshi@enterprisedb.com
In reply to: Ashutosh Bapat (#2)
Re: Test patch for partitionwise join with partitioned tables containing default partition

On Wed, Jun 6, 2018 at 11:32 AM, Ashutosh Bapat <
ashutosh.bapat@enterprisedb.com> wrote:

Thanks Rajkumar for starting a new thread. Please update the
commitfest entry as well.

I have attached new thread in commitfest and detached the old one.

Thanks & Regards,
Rajkumar Raghuwanshi
QMG, EnterpriseDB Corporation

#4Rajkumar Raghuwanshi
Rajkumar Raghuwanshi
rajkumar.raghuwanshi@enterprisedb.com
In reply to: Rajkumar Raghuwanshi (#3)
Re: Test patch for partitionwise join with partitioned tables containing default partition

Thanks for commit Jeff. Thanks for review Ashutosh, Thomas.

commit 4513d3a4be0bb7d0141f8b7eaf669a55c08e41b0
Author: Jeff Davis <jdavis@postgresql.org>
Date: Thu Jul 5 18:56:12 2018 -0700

Add test for partitionwise join involving default partition.

Author: Rajkumar Raghuwanshi
Reviewed-by: Ashutosh Bapat
Discussion:
/messages/by-id/CAKcux6ky5YeZAY74qSh-ayPZZEQchz092g71iXXbC0+E3xoscA@mail.gmail.com
Discussion:
/messages/by-id/CAKcux6kOQ85Xtzxu3tM1mR7Vk=7Z2e4rG7dL1iMZqPgLMpxQYg@mail.gmail.com

Thanks & Regards,
Rajkumar Raghuwanshi
QMG, EnterpriseDB Corporation

On Wed, Jun 6, 2018 at 12:03 PM, Rajkumar Raghuwanshi <
rajkumar.raghuwanshi@enterprisedb.com> wrote:

Show quoted text

On Wed, Jun 6, 2018 at 11:32 AM, Ashutosh Bapat <
ashutosh.bapat@enterprisedb.com> wrote:

Thanks Rajkumar for starting a new thread. Please update the
commitfest entry as well.

I have attached new thread in commitfest and detached the old one.

Thanks & Regards,
Rajkumar Raghuwanshi
QMG, EnterpriseDB Corporation