Fix obsolete comment
Hi.
A comment in ExecUpdate refers to an argument of ExecConstraints that no
longer exists. Attached fixes that, but I'm about over a year too late
[1]: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=c0a8ae7be392
Thanks,
Amit
[1]: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=c0a8ae7be392
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=c0a8ae7be392
Attachments:
ExecUpdate-obsolete-comment.patchtext/plain; charset=UTF-8; name=ExecUpdate-obsolete-comment.patchDownload
diff --git a/src/backend/executor/nodeModifyTable.c b/src/backend/executor/nodeModifyTable.c
index c4c841cdd7..2a4dfea151 100644
--- a/src/backend/executor/nodeModifyTable.c
+++ b/src/backend/executor/nodeModifyTable.c
@@ -1162,13 +1162,10 @@ lreplace:;
}
/*
- * Check the constraints of the tuple. Note that we pass the same
- * slot for the orig_slot argument, because unlike ExecInsert(), no
- * tuple-routing is performed here, hence the slot remains unchanged.
- * We've already checked the partition constraint above; however, we
- * must still ensure the tuple passes all other constraints, so we
- * will call ExecConstraints() and have it validate all remaining
- * checks.
+ * Check the constraints of the tuple. We've already checked the
+ * partition constraint above; however, we must still ensure the tuple
+ * passes all other constraints, so we will call ExecConstraints() and
+ * have it validate all remaining checks.
*/
if (resultRelationDesc->rd_att->constr)
ExecConstraints(resultRelInfo, slot, estate, false);
On 07/06/18 09:43, Amit Langote wrote:
A comment in ExecUpdate refers to an argument of ExecConstraints that no
longer exists. Attached fixes that, but I'm about over a year too late
[1] in sending this patch.
Applied, thanks!
- Heikki
On 2018/06/07 16:03, Heikki Linnakangas wrote:
On 07/06/18 09:43, Amit Langote wrote:
A comment in ExecUpdate refers to an argument of ExecConstraints that no
longer exists. Attached fixes that, but I'm about over a year too late
[1] in sending this patch.Applied, thanks!
Thanks Heikki.
Regards,
Amit